From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 52C2A8E5D for ; Thu, 24 Sep 2015 11:51:21 +0200 (CEST) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 814D2C0B1B28; Thu, 24 Sep 2015 09:51:20 +0000 (UTC) Received: from [10.36.4.249] (vpn1-4-249.ams2.redhat.com [10.36.4.249]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8O9pGdV011927; Thu, 24 Sep 2015 05:51:18 -0400 To: Yuanhan Liu References: <20150921020619.GN2339@yliu-dev.sh.intel.com> <560044CE.4040002@gmail.com> <20150922073132.GT2339@yliu-dev.sh.intel.com> <56010CE5.1030608@redhat.com> <20150922083416.GW2339@yliu-dev.sh.intel.com> <560115A5.2020602@redhat.com> <20150922092108.GX2339@yliu-dev.sh.intel.com> <56012819.2090302@redhat.com> <20150922142220.GY2339@yliu-dev.sh.intel.com> <56016AD6.3080009@redhat.com> <20150923034612.GF2339@yliu-dev.sh.intel.com> From: Marcel Apfelbaum Message-ID: <5603C793.2080703@redhat.com> Date: Thu, 24 Sep 2015 12:51:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150923034612.GF2339@yliu-dev.sh.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Cc: dev@dpdk.org, "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH v5 resend 03/12] vhost: vring queue setup for multiple queue support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2015 09:51:21 -0000 On 09/23/2015 06:46 AM, Yuanhan Liu wrote: > On Tue, Sep 22, 2015 at 05:51:02PM +0300, Marcel Apfelbaum wrote: [...] >>> It's proved to work after the fix (at least in my testing), but >>> it's late here and I'm gonna send a new version tomorrow, including >>> some other comments addressing. Please do more test then :) >>> > > It's unlikely that I will send another version unless I have clear clue > how to address a comment from Michael about vring flush. Hi, I don't pretend to understand how exactly this works in DPDK, but since the objective is to not have packets in vring you could: 1. Disable the vq processing of new packets. (You introduced the 'enable' flag) 2. Wait a reasonable amount of time until the processing cores finish dealing with current packets. 3. Check the vqs that no packets are waiting for processing. Again, this is only a suggestion and may be incomplete (or naive). > > But anyway, you still could help me to prove the fix works. You can > apply the attachment on top of my old patchset, and it should work. > I tested it and it works just fine! Thanks again, Marcel > --yliu >> >> Those are very good news! >> Tomorrow we have holidays but the day after that I'll try it for sure. >