From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-la0-f45.google.com (mail-la0-f45.google.com [209.85.215.45]) by dpdk.org (Postfix) with ESMTP id 8D0D15683 for ; Sat, 26 Sep 2015 15:43:13 +0200 (CEST) Received: by laclj5 with SMTP id lj5so28018913lac.3 for ; Sat, 26 Sep 2015 06:43:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:from:date:subject:to; bh=N+VVy94zCY5L5XAqQXH3huP0oEauPlhlGoF6IR9nR+s=; b=0RcmcBNBUgDqWhN8qkdNEO+09bsmF0PVo4rpsrgSDkvDmJKVsMC2HOD30ituAphVQx 2wnnerZUIVN1EvG1rYyH4BN2wx/umkDymx79ewv8OI0is+SP5ENuGSNUCwxrfzMTlYXK Gb5lXbwMgrhFQCOKFM8scBp6Iuj/yWdSbYw08N99Vc5Pcjs2k0IdtAYDZmCrSD+zMAbX u6PDG92HBxEZAF19TxrtZMPiX+u55vsbaa+N4eRbq5NnMNFMTHGk5ewNzx+cFkgTFOwY DYFJ+WsBRHT0/yTnY03pf3WG9D9tj41QmqpvHZgMetiSIiYQdRqhuOnNxGXaMugwZEvZ G7og== X-Received: by 10.25.16.35 with SMTP id f35mr1986841lfi.1.1443274993205; Sat, 26 Sep 2015 06:43:13 -0700 (PDT) Received: from localhost (188-67-107-13.bb.dnainternet.fi. [188.67.107.13]) by smtp.gmail.com with ESMTPSA id 30sm999395lfy.20.2015.09.26.06.43.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 26 Sep 2015 06:43:12 -0700 (PDT) Message-ID: <5606a0f0.9e18190a.7bb4d.44f4@mx.google.com> Received: by localhost (sSMTP sendmail emulation); Sat, 26 Sep 2015 16:43:10 +0300 From: Christoph Gysin Date: Sat, 26 Sep 2015 16:09:41 +0300 To: dev@dpdk.org Subject: [dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Sep 2015 13:43:13 -0000 'virtual' is a keyword and can't be used if the code is to compile with C++ compilers. If rte_devargs.h was included in C++ code, compilation with clang++ failed with an error. g++ did not fail, but only because of a bug that treats it as an anonymous struct with a decl-specifier which it ignores. This simply renames the member to 'virt'. --- app/test/test_devargs.c | 4 ++-- lib/librte_eal/common/eal_common_dev.c | 4 ++-- lib/librte_eal/common/eal_common_devargs.c | 8 ++++---- lib/librte_eal/common/include/rte_devargs.h | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/app/test/test_devargs.c b/app/test/test_devargs.c index f7fc59c..049f32d 100644 --- a/app/test/test_devargs.c +++ b/app/test/test_devargs.c @@ -91,8 +91,8 @@ test_devargs(void) if (rte_eal_devargs_add(RTE_DEVTYPE_VIRTUAL, "eth_ring1,k1=val,k2=val2") < 0) goto fail; devargs = TAILQ_FIRST(&devargs_list); - if (strncmp(devargs->virtual.drv_name, "eth_ring1", - sizeof(devargs->virtual.drv_name)) != 0) + if (strncmp(devargs->virt.drv_name, "eth_ring1", + sizeof(devargs->virt.drv_name)) != 0) goto fail; if (!devargs->args || strcmp(devargs->args, "k1=val,k2=val2") != 0) goto fail; diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c index 4089d66..a8a4146 100644 --- a/lib/librte_eal/common/eal_common_dev.c +++ b/lib/librte_eal/common/eal_common_dev.c @@ -107,10 +107,10 @@ rte_eal_dev_init(void) if (devargs->type != RTE_DEVTYPE_VIRTUAL) continue; - if (rte_eal_vdev_init(devargs->virtual.drv_name, + if (rte_eal_vdev_init(devargs->virt.drv_name, devargs->args)) { RTE_LOG(ERR, EAL, "failed to initialize %s device\n", - devargs->virtual.drv_name); + devargs->virt.drv_name); return -1; } } diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c index ec56165..5d075d0 100644 --- a/lib/librte_eal/common/eal_common_devargs.c +++ b/lib/librte_eal/common/eal_common_devargs.c @@ -107,9 +107,9 @@ rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str) break; case RTE_DEVTYPE_VIRTUAL: /* save driver name */ - ret = snprintf(devargs->virtual.drv_name, - sizeof(devargs->virtual.drv_name), "%s", buf); - if (ret < 0 || ret >= (int)sizeof(devargs->virtual.drv_name)) + ret = snprintf(devargs->virt.drv_name, + sizeof(devargs->virt.drv_name), "%s", buf); + if (ret < 0 || ret >= (int)sizeof(devargs->virt.drv_name)) goto fail; break; @@ -169,7 +169,7 @@ rte_eal_devargs_dump(FILE *f) devargs->args); else if (devargs->type == RTE_DEVTYPE_VIRTUAL) fprintf(f, " VIRTUAL %s %s\n", - devargs->virtual.drv_name, + devargs->virt.drv_name, devargs->args); else fprintf(f, " UNKNOWN %s\n", devargs->args); diff --git a/lib/librte_eal/common/include/rte_devargs.h b/lib/librte_eal/common/include/rte_devargs.h index 7084ae2..53c59f5 100644 --- a/lib/librte_eal/common/include/rte_devargs.h +++ b/lib/librte_eal/common/include/rte_devargs.h @@ -86,7 +86,7 @@ struct rte_devargs { struct { /** Driver name. */ char drv_name[32]; - } virtual; + } virt; }; /** Arguments string as given by user or "" for no argument. */ char *args; -- 2.5.3