From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id 261C91396 for ; Tue, 29 Sep 2015 04:24:29 +0200 (CEST) Received: by padhy16 with SMTP id hy16so190914244pad.1 for ; Mon, 28 Sep 2015 19:24:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:cc:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=9AAbcl+RnJ57JQ/8h95CrO0HdbKO4BRv6Knp0VZJm5M=; b=IrmurBWIkURzlUoWou4CepKQQ496g6TtkO9xs3WXN+1tDISPZQ3XqSz1DF0f9QBXj4 hskBiHrchTou8xrdbcLRbDc0l4v4YZwPh55p1Go2lcM7zt8IQbqrMjL4GIZ2BgXUYXSl 0epQe6fyWC/PuM+PAAAlHB600E9TnW5Fa+ncrZ+1FKcvnj5I+gKEJ7OThN3sGRmNH6Gu 40b4B6PvXi9MRc2jS3RjV8xclN/MrMGnc1gys4/CG9MuoPOZdM0DKNLJLnHnxP45nmBV SfPyCH1oO1/xmn64uVur4+qZL7MoIR99ybxrq5r/n670A09rqMWt7xZ9UOe+vKvyH9Uo Qy7A== X-Gm-Message-State: ALoCoQngwQoW/MPFWy2WLuu0bCHsJZw0lE2wHoz+dJ8xae/iiPjKoZa3XSDbDY1eloTpWrEZW9uL X-Received: by 10.66.144.199 with SMTP id so7mr30277994pab.42.1443493468265; Mon, 28 Sep 2015 19:24:28 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id on5sm8976982pbb.65.2015.09.28.19.24.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Sep 2015 19:24:27 -0700 (PDT) To: Tomasz Kulasek References: <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com> <1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com> <1436981189-3320-3-git-send-email-tomaszx.kulasek@intel.com> From: Tetsuya Mukawa X-Enigmail-Draft-Status: N1110 Message-ID: <5609F65A.6050208@igel.co.jp> Date: Tue, 29 Sep 2015 11:24:26 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1436981189-3320-3-git-send-email-tomaszx.kulasek@intel.com> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCHv4 2/9] null: fix segfault when null_pmd added to bonding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2015 02:24:29 -0000 On 2015/07/16 2:26, Tomasz Kulasek wrote: > When device is added to the bonding, the link status callback is added to > the slave's eth_dev->link_intr_cbs list. This list is not initialized for > null pmd and adding it to the bonding segfaults application. > > This patch allocates and sets up required structures. > > Signed-off-by: Tomasz Kulasek > --- > drivers/net/null/rte_eth_null.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c > index e244595..a8b3191 100644 > --- a/drivers/net/null/rte_eth_null.c > +++ b/drivers/net/null/rte_eth_null.c > @@ -386,6 +386,7 @@ eth_dev_null_create(const char *name, > const unsigned nb_rx_queues = 1; > const unsigned nb_tx_queues = 1; > struct rte_eth_dev_data *data = NULL; > + struct eth_driver *eth_drv = NULL; Hi Tomasz, Thanks for extending null pmd features. Is it possible to use rte_null_pmd here? Could you please check ring pmd? It may also uses rte_ring_pmd for link status callback. Tetsuya