Re: [dpdk-dev] [PATCHv4 5/9] null: export eth_dev_null_create

[Tetsuya Mukawa <mukawa@igel.co.jp>]

On 2015/07/16 2:26, Tomasz Kulasek wrote:
> To use eth_dev_null_create in application this method needs to be exported.
>
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> ---
>  drivers/net/null/Makefile                 |    2 +-
>  drivers/net/null/rte_eth_null.c           |    3 ++-
>  drivers/net/null/rte_eth_null.h           |   40 +++++++++++++++++++++++++++++
>  drivers/net/null/rte_pmd_null_version.map |    7 +++++
>  4 files changed, 50 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/net/null/rte_eth_null.h
>
> diff --git a/drivers/net/null/Makefile b/drivers/net/null/Makefile
> index 6472015..b33f9fd 100644
> --- a/drivers/net/null/Makefile
> +++ b/drivers/net/null/Makefile
> @@ -51,7 +51,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += rte_eth_null.c
>  #
>  # Export include files
>  #
> -SYMLINK-y-include +=
> +SYMLINK-y-include += rte_eth_null.h
>  
>  # this lib depends upon:
>  DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += lib/librte_mbuf
> diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
> index f393422..8ae6ebf 100644
> --- a/drivers/net/null/rte_eth_null.c
> +++ b/drivers/net/null/rte_eth_null.c
> @@ -2,6 +2,7 @@
>   *   BSD LICENSE
>   *
>   *   Copyright (C) IGEL Co.,Ltd.
> + *   Copyright (c) 2015 Intel Corporation.
>   *   All rights reserved.
>   *
>   *   Redistribution and use in source and binary forms, with or without
> @@ -481,7 +482,7 @@ static const struct eth_dev_ops ops = {
>  	.rss_hash_conf_get = eth_rss_hash_conf_get
>  };
>  
> -static int
> +int
>  eth_dev_null_create(const char *name,
>  		const unsigned numa_node,
>  		unsigned packet_size,
> diff --git a/drivers/net/null/rte_eth_null.h b/drivers/net/null/rte_eth_null.h
> new file mode 100644
> index 0000000..abada8c
> --- /dev/null
> +++ b/drivers/net/null/rte_eth_null.h
> @@ -0,0 +1,40 @@
> +/*-
> + *   BSD LICENSE
> + *
> + *   Copyright(c) 2015 Intel Corporation. All rights reserved.
> + *   All rights reserved.
> + *
> + *   Redistribution and use in source and binary forms, with or without
> + *   modification, are permitted provided that the following conditions
> + *   are met:
> + *
> + *     * Redistributions of source code must retain the above copyright
> + *       notice, this list of conditions and the following disclaimer.
> + *     * Redistributions in binary form must reproduce the above copyright
> + *       notice, this list of conditions and the following disclaimer in
> + *       the documentation and/or other materials provided with the
> + *       distribution.
> + *     * Neither the name of Intel Corporation nor the names of its
> + *       contributors may be used to endorse or promote products derived
> + *       from this software without specific prior written permission.
> + *
> + *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> + *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> + *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> + *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> + *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> + *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> + *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> + *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> + *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> + *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> + *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +#ifndef RTE_ETH_NULL_H_
> +#define RTE_ETH_NULL_H_
> +
> +int eth_dev_null_create(const char *name, const unsigned numa_node,
> +		unsigned packet_size, unsigned packet_copy);
> +
> +#endif /* RTE_ETH_NULL_H_ */
> diff --git a/drivers/net/null/rte_pmd_null_version.map b/drivers/net/null/rte_pmd_null_version.map
> index ef35398..2b2a743 100644
> --- a/drivers/net/null/rte_pmd_null_version.map
> +++ b/drivers/net/null/rte_pmd_null_version.map
> @@ -2,3 +2,10 @@ DPDK_2.0 {
>  
>  	local: *;
>  };
> +
> +DPDK_2.1 {
> +	global:
> +
> +	eth_dev_null_create;
> +
> +} DPDK_2.0;

Hi Thomasz,

I don't have any comments without the version miss Thomas has already
commented.

Tetsuya