From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) by dpdk.org (Postfix) with ESMTP id BF8C15681 for ; Tue, 29 Sep 2015 04:28:48 +0200 (CEST) Received: by pablk4 with SMTP id lk4so94146973pab.3 for ; Mon, 28 Sep 2015 19:28:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=fhxEBsCL9sOS3LtApBAIDU0eMg/8OxTp12pYVT8oCDA=; b=QnLkWSYDMClNObbtgbkcZ6cj+EOpzah0yTro80xXkaDHwKzogNNF1fvKkl/RHeykGa H1WOH0KeHW9mz3hWbWqBdxwoMSeYsgGuvgD4UUqpz6MGqS8N83Yn8yJlRqVrgl9KkxW1 1Rp//N/nfo+R1Uef/tn4ZCgqQl/97RR2PSa+Y+b2+SsqmmxSiQb1v4M/v9t+dxj42Pk8 bhfoochBeL+mQ7kT9QRb6aC4/nctw3l/sv+ootr9L7OOOp6vFul/IqATMJU9MHSHCQLj hAYxDd8ccHgR242xY3riCfwEuhtLzR1MWfDxdiKAFcl6JgOCU0v9YioIShOpVlc7Gom9 lpCQ== X-Gm-Message-State: ALoCoQnuS66wPEQlp3DVS9gMTeV1uF7FxVSuGZzSurxy/U1/iQLJos0vRSQBvw0salVfmX3wriIz X-Received: by 10.66.97.73 with SMTP id dy9mr30115161pab.115.1443493728009; Mon, 28 Sep 2015 19:28:48 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id sv9sm14760884pbc.44.2015.09.28.19.28.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Sep 2015 19:28:47 -0700 (PDT) To: Tomasz Kulasek , dev@dpdk.org References: <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com> <1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com> <1436981189-3320-6-git-send-email-tomaszx.kulasek@intel.com> From: Tetsuya Mukawa X-Enigmail-Draft-Status: N1110 Message-ID: <5609F75E.1040901@igel.co.jp> Date: Tue, 29 Sep 2015 11:28:46 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1436981189-3320-6-git-send-email-tomaszx.kulasek@intel.com> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCHv4 5/9] null: export eth_dev_null_create X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2015 02:28:49 -0000 On 2015/07/16 2:26, Tomasz Kulasek wrote: > To use eth_dev_null_create in application this method needs to be exported. > > Signed-off-by: Tomasz Kulasek > --- > drivers/net/null/Makefile | 2 +- > drivers/net/null/rte_eth_null.c | 3 ++- > drivers/net/null/rte_eth_null.h | 40 +++++++++++++++++++++++++++++ > drivers/net/null/rte_pmd_null_version.map | 7 +++++ > 4 files changed, 50 insertions(+), 2 deletions(-) > create mode 100644 drivers/net/null/rte_eth_null.h > > diff --git a/drivers/net/null/Makefile b/drivers/net/null/Makefile > index 6472015..b33f9fd 100644 > --- a/drivers/net/null/Makefile > +++ b/drivers/net/null/Makefile > @@ -51,7 +51,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += rte_eth_null.c > # > # Export include files > # > -SYMLINK-y-include += > +SYMLINK-y-include += rte_eth_null.h > > # this lib depends upon: > DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += lib/librte_mbuf > diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c > index f393422..8ae6ebf 100644 > --- a/drivers/net/null/rte_eth_null.c > +++ b/drivers/net/null/rte_eth_null.c > @@ -2,6 +2,7 @@ > * BSD LICENSE > * > * Copyright (C) IGEL Co.,Ltd. > + * Copyright (c) 2015 Intel Corporation. > * All rights reserved. > * > * Redistribution and use in source and binary forms, with or without > @@ -481,7 +482,7 @@ static const struct eth_dev_ops ops = { > .rss_hash_conf_get = eth_rss_hash_conf_get > }; > > -static int > +int > eth_dev_null_create(const char *name, > const unsigned numa_node, > unsigned packet_size, > diff --git a/drivers/net/null/rte_eth_null.h b/drivers/net/null/rte_eth_null.h > new file mode 100644 > index 0000000..abada8c > --- /dev/null > +++ b/drivers/net/null/rte_eth_null.h > @@ -0,0 +1,40 @@ > +/*- > + * BSD LICENSE > + * > + * Copyright(c) 2015 Intel Corporation. All rights reserved. > + * All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in > + * the documentation and/or other materials provided with the > + * distribution. > + * * Neither the name of Intel Corporation nor the names of its > + * contributors may be used to endorse or promote products derived > + * from this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + */ > + > +#ifndef RTE_ETH_NULL_H_ > +#define RTE_ETH_NULL_H_ > + > +int eth_dev_null_create(const char *name, const unsigned numa_node, > + unsigned packet_size, unsigned packet_copy); > + > +#endif /* RTE_ETH_NULL_H_ */ > diff --git a/drivers/net/null/rte_pmd_null_version.map b/drivers/net/null/rte_pmd_null_version.map > index ef35398..2b2a743 100644 > --- a/drivers/net/null/rte_pmd_null_version.map > +++ b/drivers/net/null/rte_pmd_null_version.map > @@ -2,3 +2,10 @@ DPDK_2.0 { > > local: *; > }; > + > +DPDK_2.1 { > + global: > + > + eth_dev_null_create; > + > +} DPDK_2.0; Hi Thomasz, I don't have any comments without the version miss Thomas has already commented. Tetsuya