DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tetsuya Mukawa <mukawa@igel.co.jp>
To: Ravi Kerur <rkerur@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id
Date: Tue, 29 Sep 2015 12:32:19 +0900	[thread overview]
Message-ID: <560A0643.7050800@igel.co.jp> (raw)
In-Reply-To: <CAFb4SLCHP8+b_GU0Y6Y_etxxOyzHGD9dV_9Rh01E24U6ZsT1nw@mail.gmail.com>

On 2015/09/24 6:22, Ravi Kerur wrote:
> Hi David, Tetsuya,
>
> I have sent V3 (changes isolated to rte_ether component) for formal review.
> Please look into it and let me know your inputs.

Hi Ravi,

I've checked the patch.
I guess your patch is good.

>
> @David: I looked at "rte_eth_dev_get_port_by_name()", this function is
> similar to "rte_eth_dev_get_name_by_port" and I have used same logic. Let
> me know if this not correct I can fix both.

Do you comment about rte_eth_dev_get_port_by_name and
rte_eth_dev_get_port_by_addr?
If so, I guess we don't need to merge.

> Thanks,
> Ravi
>
>
> On Tue, Sep 15, 2015 at 4:28 AM, Ravi Kerur <rkerur@gmail.com> wrote:
>
>> Hi David,
>>
>>
>> On Thu, Sep 3, 2015 at 7:04 AM, David Marchand <david.marchand@6wind.com>
>> wrote:
>>
>>> Hello Ravi, Tetsuya,
>>>
>>> On Tue, Aug 25, 2015 at 7:59 PM, Ravi Kerur <rkerur@gmail.com> wrote:
>>>
>>>> Let us know how you want us to fix this? To fix rte_eal_vdev_init and
>>>> rte_eal_pci_probe_one to return allocated port_id we had 2 approaches
>>>> mentioned in earlier discussion. In addition to those we have another
>>>> approach with changes isolated only to rte_ether component. I am attaching
>>>> diffs (preliminary) with this email. Please let us know your inputs since
>>>> it involves EAL component.
>>>>
>>> - This patch looks like a good ethdev cleanup (even if it really lacks
>>> some context / commit log).
>>>
>>> I wonder just why you only take the first part of the name in
>>> rte_eth_dev_get_port_by_name().
>>> Would not this match, let's say, both toto and toto0 vdevs ?
>>> Is this intended ?
>>>
>>> It was not intended, i will look into it.
>>> - In the end, with this patch, do we still need to update eal ?
>>> Looking at the code, I am not sure anymore.
>>>
>> Approach 3 (preliminary diffs sent as an attachment) doesn't involve EAL
>> but the other two solutions do. So please let us know which one you prefer.
>> I will send updated patch.
>>
>> Thanks,
>> Ravi
>>
>>
>>>
>>>
>>> --
>>> David Marchand
>>>
>>

  parent reply	other threads:[~2015-09-29  3:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19 19:42 [dpdk-dev] [PATCH v2] Send updated port_id in vdev_init functions Ravi Kerur
2015-08-19 19:42 ` [dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id Ravi Kerur
2015-08-20  2:07   ` Tetsuya Mukawa
2015-08-20 19:16     ` Ravi Kerur
2015-08-21  3:33       ` Tetsuya Mukawa
2015-08-25 17:59         ` Ravi Kerur
2015-09-03 14:04           ` David Marchand
2015-09-15 11:28             ` Ravi Kerur
2015-09-23 21:22               ` Ravi Kerur
2015-09-26 11:35                 ` Tetsuya Mukawa
2015-09-29  3:32                 ` Tetsuya Mukawa [this message]
2015-09-30 19:14                   ` Ravi Kerur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560A0643.7050800@igel.co.jp \
    --to=mukawa@igel.co.jp \
    --cc=dev@dpdk.org \
    --cc=rkerur@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).