From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id AB8F212A8 for ; Tue, 29 Sep 2015 05:32:21 +0200 (CEST) Received: by pablk4 with SMTP id lk4so95706253pab.3 for ; Mon, 28 Sep 2015 20:32:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=QWqLzwqFAVR67xDq5MsPUgD93sc/8wcdSb49O3KKKzw=; b=IsN6JAvFOMdmL5asEHDDkZXALCLtkjW35HA8j7tyePmZ0BO2xYEM72g3hTNiHLfmMa ShkQk3x4ruaYGFfWI41oq3q0qZk6RPFc9xTAINLdT6laVdkrvnz2XXnTAvTyb2bOx4eH OdWBtOoaToX9/nGWDXFxdH9LWb4Z6qDd/hPMiV8NMH3w3StQzUFqFl8jRzjH6elQpH74 t+E2Ehm9xAFqGjfrS1qsBqf9AJ2dOlwgXDXecfyApopkqPAvP9V+oe/0gpSRNS0tNmBM 1xqpBHGMNIiDmJmqvU/7DkXkVfEhiJZOnU6TgUZ+U6J+gZzwCtbgUy9lTQKkxJoOoVc4 kolA== X-Gm-Message-State: ALoCoQk74VZgYGjDxoCHMr3njUVMek4k1jODEwGZ1T0jxH2JFktZ7WFR4pVVAoNa92zWxPnm/zRj X-Received: by 10.68.242.130 with SMTP id wq2mr29978243pbc.117.1443497540944; Mon, 28 Sep 2015 20:32:20 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id bk8sm22335407pad.18.2015.09.28.20.32.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Sep 2015 20:32:20 -0700 (PDT) To: Ravi Kerur References: <1440013341-29659-1-git-send-email-rkerur@gmail.com> <1440013376-29715-1-git-send-email-rkerur@gmail.com> <55D53655.1040808@igel.co.jp> <55D69C00.2020609@igel.co.jp> From: Tetsuya Mukawa X-Enigmail-Draft-Status: N1110 Message-ID: <560A0643.7050800@igel.co.jp> Date: Tue, 29 Sep 2015 12:32:19 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2015 03:32:22 -0000 On 2015/09/24 6:22, Ravi Kerur wrote: > Hi David, Tetsuya, > > I have sent V3 (changes isolated to rte_ether component) for formal review. > Please look into it and let me know your inputs. Hi Ravi, I've checked the patch. I guess your patch is good. > > @David: I looked at "rte_eth_dev_get_port_by_name()", this function is > similar to "rte_eth_dev_get_name_by_port" and I have used same logic. Let > me know if this not correct I can fix both. Do you comment about rte_eth_dev_get_port_by_name and rte_eth_dev_get_port_by_addr? If so, I guess we don't need to merge. > Thanks, > Ravi > > > On Tue, Sep 15, 2015 at 4:28 AM, Ravi Kerur wrote: > >> Hi David, >> >> >> On Thu, Sep 3, 2015 at 7:04 AM, David Marchand >> wrote: >> >>> Hello Ravi, Tetsuya, >>> >>> On Tue, Aug 25, 2015 at 7:59 PM, Ravi Kerur wrote: >>> >>>> Let us know how you want us to fix this? To fix rte_eal_vdev_init and >>>> rte_eal_pci_probe_one to return allocated port_id we had 2 approaches >>>> mentioned in earlier discussion. In addition to those we have another >>>> approach with changes isolated only to rte_ether component. I am attaching >>>> diffs (preliminary) with this email. Please let us know your inputs since >>>> it involves EAL component. >>>> >>> - This patch looks like a good ethdev cleanup (even if it really lacks >>> some context / commit log). >>> >>> I wonder just why you only take the first part of the name in >>> rte_eth_dev_get_port_by_name(). >>> Would not this match, let's say, both toto and toto0 vdevs ? >>> Is this intended ? >>> >>> It was not intended, i will look into it. >>> - In the end, with this patch, do we still need to update eal ? >>> Looking at the code, I am not sure anymore. >>> >> Approach 3 (preliminary diffs sent as an attachment) doesn't involve EAL >> but the other two solutions do. So please let us know which one you prefer. >> I will send updated patch. >> >> Thanks, >> Ravi >> >> >>> >>> >>> -- >>> David Marchand >>> >>