From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 2114112A8 for ; Tue, 29 Sep 2015 11:29:02 +0200 (CEST) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 0F81E91C19; Tue, 29 Sep 2015 09:29:01 +0000 (UTC) Received: from dhcp195.koti.laiskiainen.org (vpn1-4-108.ams2.redhat.com [10.36.4.108]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8T9Sx4s006220; Tue, 29 Sep 2015 05:29:00 -0400 To: Mario Carrillo , dev@dpdk.org References: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1443484863-18652-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1443484863-18652-4-git-send-email-mario.alfredo.c.arevalo@intel.com> From: Panu Matilainen Message-ID: <560A59DB.7020500@redhat.com> Date: Tue, 29 Sep 2015 12:28:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1443484863-18652-4-git-send-email-mario.alfredo.c.arevalo@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Subject: Re: [dpdk-dev] [PATCH v2 3/8] mk: Add rule for installing libraries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2015 09:29:02 -0000 On 09/29/2015 03:00 AM, Mario Carrillo wrote: > Add hierarchy-file support to the DPDK libraries, > when invoking "make install-lib" for this case > if the architecture is 64 bits libraries will be instaled > in: $(DESTDIR)/usr/lib64 else it will be $(DESTDIR)/usr/lib > This hierarchy is based on: > http://www.freedesktop.org/software/systemd/man/file-hierarchy.html > > Signed-off-by: Mario Carrillo > --- > mk/rte.sdkinstall.mk | 20 ++++++++++++++++++++ > mk/rte.sdkroot.mk | 4 ++-- > 2 files changed, 22 insertions(+), 2 deletions(-) > > diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk > index 44e770d..9a54fb6 100644 > --- a/mk/rte.sdkinstall.mk > +++ b/mk/rte.sdkinstall.mk > @@ -47,6 +47,14 @@ INCLUDE_DIR := $(DESTDIR)/usr/include/dpdk > BIN_DIR := $(DESTDIR)/usr/bin > HSLINKS := $(wildcard $(RTE_OUTPUT)/include/*) > BINARY_FILES := $(patsubst %.map,,$(wildcard $(RTE_OUTPUT)/app/*)) > +LIBS := $(wildcard $(RTE_OUTPUT)/lib/*) > +include $(BUILD_DIR)/build/.config > +RTE_ARCH := $(CONFIG_RTE_ARCH:"%"=%) > +ifeq ($(RTE_ARCH),x86_64) > +LIB_DIR := /usr/lib64 > +else > +LIB_DIR := /usr/lib > +endif > endif > endif Like explained in http://dpdk.org/ml/archives/dev/2015-September/023839.html, this arch-based heuristics for LIB_DIR will be wrong at least as often as it is sort of right. Better IMO just to default to /usr/lib and let people override than try to be clever (and fail): LIB_DIR ?= /usr/lib > > @@ -103,6 +111,18 @@ install-bin: > echo installing: $$BIN_FILE; \ > done > # > +# if architecture is 64 bits install in /usr/lib64 > +# else /usr/lib > +# > +.PHONY: install-lib > +install-lib: > + @echo ================== Installing libraries > + @[ -d $(LIB_DIR) ] || mkdir -p $(LIB_DIR) > + @for LIB in ${LIBS}; do \ > + cp -rf $$LIB ${LIB_DIR}; \ This doesn't honor $DESTDIR. - Panu -