From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mukawa@igel.co.jp>
Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com
 [209.85.220.49]) by dpdk.org (Postfix) with ESMTP id E81245683
 for <dev@dpdk.org>; Tue, 29 Sep 2015 12:33:00 +0200 (CEST)
Received: by pablk4 with SMTP id lk4so2777752pab.3
 for <dev@dpdk.org>; Tue, 29 Sep 2015 03:33:00 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:subject:to:references:cc:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-type
 :content-transfer-encoding;
 bh=eGNDAGjy5mUWNyep6jYPHkRdeLLBu+CJPQ6kIXDySC4=;
 b=fAOLWk3tLy6OJ61R5NI20MSv7o6LAtr6uBSbMRfDIiEtotuJvUqqqFXArG0bwVbe1S
 i1FQlbFLo6/IjWOPrhD4EuUbmObFKkHDdxmkaaHuDFo3IzLOjDAF4vpieyPGtihYY8Jh
 Bawx9Z5Iy7qmTlJR5r/8N1BWj7mEA4xRFFMlLWYoXFxjjO7yQXzkBAFbZ7soE6nkxaRd
 g5/J/XeqScDJO/Za9MLQ+11jl2ofZEL6haP0d/4p8mO+BtpdBsWcqXpPsMXsfH1tuorl
 hFDpb84BT/8LVAMgxz1vS29TwB/nFGWFWYPDDfIizHU8YZir3Ov1wUsKZ8fQkAHLPoHz
 8Xzg==
X-Gm-Message-State: ALoCoQl4Kw89L61KNDZKdGPpFWWWQF5ZJsNDIecct+4mlf62zUGW5HVPTMZhVTF3DrT/AzmWSYiJ
X-Received: by 10.68.137.161 with SMTP id qj1mr32542312pbb.14.1443522780244;
 Tue, 29 Sep 2015 03:33:00 -0700 (PDT)
Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132])
 by smtp.googlemail.com with ESMTPSA id ct2sm24684185pbc.34.2015.09.29.03.32.58
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 29 Sep 2015 03:32:59 -0700 (PDT)
To: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>
References: <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com>
 <1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com>
 <1436981189-3320-3-git-send-email-tomaszx.kulasek@intel.com>
 <5609F65A.6050208@igel.co.jp>
 <3042915272161B4EB253DA4D77EB373A14DF7A48@IRSMSX102.ger.corp.intel.com>
From: Tetsuya Mukawa <mukawa@igel.co.jp>
X-Enigmail-Draft-Status: N1110
Message-ID: <560A68DA.4060309@igel.co.jp>
Date: Tue, 29 Sep 2015 19:32:58 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <3042915272161B4EB253DA4D77EB373A14DF7A48@IRSMSX102.ger.corp.intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCHv4 2/9] null: fix segfault when null_pmd added
 to bonding
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Sep 2015 10:33:01 -0000

On 2015/09/29 18:39, Kulasek, TomaszX wrote:
> Hi Tetsuya,
>
>> Thanks for extending null pmd features.
>> Is it possible to use rte_null_pmd here?
>> Could you please check ring pmd? It may also uses rte_ring_pmd for link
>> status callback.
>>
>> Tetsuya
> My first attempt was to use ring pmd, and there's no such an issue with it. It works pretty well in bonding.
>
> Tomasz.

HI Tomasz,


Sorry, my English is wrong.
'rte_null_pmd' is defined like below.

static struct eth_driver rte_null_pmd = {
        .pci_drv = {
                .name = "rte_null_pmd",
                .drv_flags = RTE_PCI_DRV_DETACHABLE,
        },
};

I guess you may be able to use 'rte_null_pmd' instead of allocating one
more eth_driver structure like below.

    struct eth_driver *eth_drv = NULL;
    eth_drv = rte_zmalloc_socket(name, sizeof(*eth_drv), 0, numa_node);

Is it possible to use 'rte_null_pmd'?

Tetsuya