From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) by dpdk.org (Postfix) with ESMTP id B663E5A45 for ; Wed, 30 Sep 2015 03:24:42 +0200 (CEST) Received: by padhy16 with SMTP id hy16so22162744pad.1 for ; Tue, 29 Sep 2015 18:24:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=YSYQVaWKgbWXXy8ISGY8HjzdV4OUsDXR14Hz4w5142k=; b=L2LQhh274SyvXA6fT8LFIQFkQ3fEjSgLJJR144fzrivCXORAKj0unqbpylPKMkJr90 5nRrJARmqrnXW6PNPF2sIHs9n7gqfHdDJ13y18ZUHmejdrc693mkFJJedfrm06pBfKbC crsu0U9j9cNT3tcCcAb+7M68xromAAFC5PmVlhAyAsI8rBJVQnt5+OlV6KUR+kq1CuUV wjqjj0cqh5mGCU8DhMrE6eksqArsv/E0LNTZzCyB0KVmUzuIzsq2ecBkwLe2TznI6w1h OLDhIr1iXqVjaIQ6u8s56QmOXWHEIurH7XsQtIK4Xfy3TdbJnRTjcRqs8KPYCGxkCcrw OSqA== X-Gm-Message-State: ALoCoQnfoNV2J9jpAAbFRaNKYdvBGB8X8I/h959cOpTVRORZbOOoeBYNcqHli928slgon6kSooaf X-Received: by 10.66.55.41 with SMTP id o9mr1376465pap.44.1443576281929; Tue, 29 Sep 2015 18:24:41 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id gw3sm27934363pbc.46.2015.09.29.18.24.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Sep 2015 18:24:41 -0700 (PDT) To: "Kulasek, TomaszX" References: <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com> <1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com> <1436981189-3320-3-git-send-email-tomaszx.kulasek@intel.com> <5609F65A.6050208@igel.co.jp> <3042915272161B4EB253DA4D77EB373A14DF7A48@IRSMSX102.ger.corp.intel.com> <560A68DA.4060309@igel.co.jp> <3042915272161B4EB253DA4D77EB373A14DF7CCD@IRSMSX102.ger.corp.intel.com> From: Tetsuya Mukawa X-Enigmail-Draft-Status: N1110 Message-ID: <560B39D7.6090708@igel.co.jp> Date: Wed, 30 Sep 2015 10:24:39 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <3042915272161B4EB253DA4D77EB373A14DF7CCD@IRSMSX102.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCHv4 2/9] null: fix segfault when null_pmd added to bonding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Sep 2015 01:24:43 -0000 On 2015/09/30 0:10, Kulasek, TomaszX wrote: > Hi Tetsuya, > > Changes from patch below, solves the problem. I've removed malloc. > > Tomasz. > > --- > From e03e77a7dc0e47ac9d750545a834624f88f61966 Mon Sep 17 00:00:00 2001 > From: Tomasz Kulasek > Date: Tue, 29 Sep 2015 16:48:31 +0200 > Subject: [PATCH 1/4] null: fix segfault when null_pmd added to bonding > > --- > drivers/net/null/rte_eth_null.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c > index e244595..b498ef1 100644 > --- a/drivers/net/null/rte_eth_null.c > +++ b/drivers/net/null/rte_eth_null.c > @@ -432,6 +432,7 @@ eth_dev_null_create(const char *name, > internals->numa_node = numa_node; > > pci_dev->numa_node = numa_node; > + pci_dev->driver = &rte_null_pmd.pci_drv; > > data->dev_private = internals; > data->port_id = eth_dev->data->port_id; > @@ -445,6 +446,7 @@ eth_dev_null_create(const char *name, > eth_dev->dev_ops = &ops; > eth_dev->pci_dev = pci_dev; > eth_dev->driver = &rte_null_pmd; > + TAILQ_INIT(ð_dev->link_intr_cbs); > > /* finally assign rx and tx ops */ > if (packet_copy) { > @@ -461,6 +463,7 @@ error: > rte_free(data); > rte_free(pci_dev); > rte_free(internals); > + rte_free(eth_dev); Hi Tomasz, We can remove rte_free(eth_dev), because if eth_dev is allocated correctly, we cannot reach here. I don't see any issues except for it. Thanks, Tetsuya