From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) by dpdk.org (Postfix) with ESMTP id C8E748D8B for ; Wed, 30 Sep 2015 03:24:46 +0200 (CEST) Received: by padhy16 with SMTP id hy16so22164568pad.1 for ; Tue, 29 Sep 2015 18:24:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=t3eKDJ8Gm/M8E1nJ7IUjLtCa7CLCFtis5ELEHAkw50Y=; b=DJd+Za2NKsQfP0zXMgzL1RXT4B/tSCz4x1f8boUxzvlElP6jdkeVbtdyJpnBkhEKM4 4uuZDUBJdtDx42p5S6ivwNKhqIUzXn9OtPqCd4J5PCd7khPNYApYFEI8hwZBWN6fgtop AXCZOhM7+Mwo/zYBT3O6mcee6NfVv0Bqnc/oNe9VnSRH+/Z0NdRQMPD7Ans1wZUyw485 Cih5SkRzS7yER0FF0seUbQJGrtBJdZYmf1yGcUqKLeLK2xC76z9tQVE+Bmm7x4X80fLC cNi96WnSMbZ79SYXb6/VuT4jdx0q9+hftJiVu0QUGMm5CUmYN3Bh00mvvIE1aFfU468k TsEA== X-Gm-Message-State: ALoCoQn1y8xcbH++eTymHgFBq8kZWjq2+FMe3G5Q9Ygp/ZzlN0EReZM9pty/vuLzNdcmWGSaKbTB X-Received: by 10.66.182.135 with SMTP id ee7mr1291550pac.95.1443576286138; Tue, 29 Sep 2015 18:24:46 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id ey3sm27941578pbd.28.2015.09.29.18.24.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Sep 2015 18:24:45 -0700 (PDT) To: "Kulasek, TomaszX" , "dev@dpdk.org" References: <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com> <1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com> <1436981189-3320-4-git-send-email-tomaszx.kulasek@intel.com> <5609F667.2010800@igel.co.jp> <3042915272161B4EB253DA4D77EB373A14DF7A5F@IRSMSX102.ger.corp.intel.com> <560A6934.6010904@igel.co.jp> <3042915272161B4EB253DA4D77EB373A14DF7B06@IRSMSX102.ger.corp.intel.com> <3042915272161B4EB253DA4D77EB373A14DF7CB7@IRSMSX102.ger.corp.intel.com> From: Tetsuya Mukawa X-Enigmail-Draft-Status: N1110 Message-ID: <560B39DC.6080401@igel.co.jp> Date: Wed, 30 Sep 2015 10:24:44 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <3042915272161B4EB253DA4D77EB373A14DF7CB7@IRSMSX102.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCHv4 3/9] null: extend number of virtual queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Sep 2015 01:24:47 -0000 On 2015/09/30 0:06, Kulasek, TomaszX wrote: > Hi Tetsuya, > > Can you check patch below? > > Thanks, > Tomasz. > --- > > From d50b0594fa34a576602c457b51cac80e7d462eed Mon Sep 17 00:00:00 2001 > From: Tomasz Kulasek > Date: Tue, 29 Sep 2015 16:52:12 +0200 > Subject: [PATCH 2/4] null: extend number of virtual queues > > --- > drivers/net/null/rte_eth_null.c | 28 +++++++++++++++++++--------- > 1 file changed, 19 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c > index b498ef1..68cb723 100644 > --- a/drivers/net/null/rte_eth_null.c > +++ b/drivers/net/null/rte_eth_null.c > @@ -71,8 +71,8 @@ struct pmd_internals { > unsigned nb_rx_queues; > unsigned nb_tx_queues; > > - struct null_queue rx_null_queues[1]; > - struct null_queue tx_null_queues[1]; > + struct null_queue rx_null_queues[RTE_MAX_QUEUES_PER_PORT]; > + struct null_queue tx_null_queues[RTE_MAX_QUEUES_PER_PORT]; > }; > > > @@ -178,7 +178,15 @@ eth_null_copy_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs) > } > > static int > -eth_dev_configure(struct rte_eth_dev *dev __rte_unused) { return 0; } > +eth_dev_configure(struct rte_eth_dev *dev) { > + struct pmd_internals *internals; > + > + internals = dev->data->dev_private; > + internals->nb_rx_queues = dev->data->nb_rx_queues; > + internals->nb_tx_queues = dev->data->nb_tx_queues; > + > + return 0; > +} > > static int > eth_dev_start(struct rte_eth_dev *dev) > @@ -213,10 +221,11 @@ eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id, > if ((dev == NULL) || (mb_pool == NULL)) > return -EINVAL; > > - if (rx_queue_id != 0) > + internals = dev->data->dev_private; > + > + if (rx_queue_id >= internals->nb_rx_queues) > return -ENODEV; > > - internals = dev->data->dev_private; > packet_size = internals->packet_size; > > internals->rx_null_queues[rx_queue_id].mb_pool = mb_pool; > @@ -246,10 +255,11 @@ eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id, > if (dev == NULL) > return -EINVAL; > > - if (tx_queue_id != 0) > + internals = dev->data->dev_private; > + > + if (tx_queue_id >= internals->nb_tx_queues) > return -ENODEV; > > - internals = dev->data->dev_private; > packet_size = internals->packet_size; > > dev->data->tx_queues[tx_queue_id] = > @@ -279,8 +289,8 @@ eth_dev_info(struct rte_eth_dev *dev, > dev_info->driver_name = drivername; > dev_info->max_mac_addrs = 1; > dev_info->max_rx_pktlen = (uint32_t)-1; > - dev_info->max_rx_queues = (uint16_t)internals->nb_rx_queues; > - dev_info->max_tx_queues = (uint16_t)internals->nb_tx_queues; > + dev_info->max_rx_queues = RTE_DIM(internals->rx_null_queues); > + dev_info->max_tx_queues = RTE_DIM(internals->tx_null_queues); > dev_info->min_rx_bufsize = 0; > dev_info->pci_dev = NULL; > } > -- > Acked-by: Tetsuya Mukawa