From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id B10A08D9E for ; Fri, 2 Oct 2015 12:49:42 +0200 (CEST) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id B4BD785544; Fri, 2 Oct 2015 10:49:41 +0000 (UTC) Received: from dhcp195.koti.laiskiainen.org (vpn1-5-73.ams2.redhat.com [10.36.5.73]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t92AnedR018695; Fri, 2 Oct 2015 06:49:41 -0400 To: Mario Carrillo , dev@dpdk.org References: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1443658313-11045-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1443658313-11045-7-git-send-email-mario.alfredo.c.arevalo@intel.com> From: Panu Matilainen Message-ID: <560E6144.7020607@redhat.com> Date: Fri, 2 Oct 2015 13:49:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1443658313-11045-7-git-send-email-mario.alfredo.c.arevalo@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Subject: Re: [dpdk-dev] [PATCH v3 6/8] mk: Add rule for installing nic bind files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2015 10:49:43 -0000 On 10/01/2015 03:11 AM, Mario Carrillo wrote: > Add hierarchy-file support to the DPDK nic bind files, > when invoking "make install-sbin" nic bind files will > be installed by default in: $(DESTDIR)/$(SBIN_DIR) > where SBIN_DIR=/usr/sbin/dpdk_nic_bind by default, > you can override SBIN_DIR var. > This hierarchy is based on: > http://www.freedesktop.org/software/systemd/man/file-hierarchy.html > and dpdk spec file. > > Signed-off-by: Mario Carrillo > --- > mk/rte.sdkinstall.mk | 14 ++++++++++++++ > mk/rte.sdkroot.mk | 4 ++-- > 2 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk > index 5a2fd40..4eecf31 100644 > --- a/mk/rte.sdkinstall.mk > +++ b/mk/rte.sdkinstall.mk > @@ -46,11 +46,13 @@ else > INCLUDE_DIR ?= /usr/include/dpdk > BIN_DIR ?= /usr/bin > DOC_DIR ?= /usr/share/doc/dpdk > +SBIN_DIR ?= /usr/sbin/dpdk_nic_bind > HSLINKS := $(wildcard $(RTE_OUTPUT)/include/*) > BINARY_FILES := $(patsubst %.map,,$(wildcard $(RTE_OUTPUT)/app/*)) > LIBS := $(wildcard $(RTE_OUTPUT)/lib/*) > MODULES := $(wildcard $(RTE_OUTPUT)/kmod/*) > DOCS := $(wildcard $(BUILD_DIR)/doc/*) > +NIC_BIND_FILES := $(wildcard $(BUILD_DIR)/tools/*nic_bind.py) > include $(BUILD_DIR)/build/.config > RTE_ARCH := $(CONFIG_RTE_ARCH:"%"=%) > RTE_EXEC_ENV := $(CONFIG_RTE_EXEC_ENV:"%"=%) > @@ -161,6 +163,18 @@ install-doc: > echo installing: $$DOC; \ > done > # > +# install nic bind files in /usr/sbin/dpdk_nic_bind > +# by default SBIN_DIR can be overridden. > +# This creates an out-of-path directory /usr/sbin/dpdk_nic_bind/ in which the dpdk_nic_bind.py is installed. Besides not being a very accessible location, the FHS explicitly forbids creation of subdirectories below /usr/[s]bin. SBIN_DIR should be /usr/sbin unless overridden, but OTOH I think this could go into /usr/bin just as well, the split is fairly ambiguous anyway (I mean, testpmd is not something a regular user is going to run either) In addition, if dpdk_nic_bind.py is installed then perhaps the cpu_layout.py utility should be installed too? - Panu -