From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id BE2848DA7 for ; Fri, 2 Oct 2015 13:15:31 +0200 (CEST) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id EC87E91E95; Fri, 2 Oct 2015 11:15:30 +0000 (UTC) Received: from dhcp195.koti.laiskiainen.org (vpn1-5-73.ams2.redhat.com [10.36.5.73]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t92BFTQD022833; Fri, 2 Oct 2015 07:15:30 -0400 To: Mario Carrillo , dev@dpdk.org References: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1443658313-11045-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1443658313-11045-9-git-send-email-mario.alfredo.c.arevalo@intel.com> From: Panu Matilainen Message-ID: <560E6751.6090901@redhat.com> Date: Fri, 2 Oct 2015 14:15:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1443658313-11045-9-git-send-email-mario.alfredo.c.arevalo@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Subject: Re: [dpdk-dev] [PATCH v3 8/8] mk: Add rule for installing runtime files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2015 11:15:32 -0000 On 10/01/2015 03:11 AM, Mario Carrillo wrote: > Add hierarchy-file support to the DPDK libraries, modules, > binary files, nic bind files and documentation, > when invoking "make install-fhs" (filesystem hierarchy standard) > runtime files will be by default installed in: > $(DESTDIR)/$(BIN_DIR) where BIN_DIR=/usr/bin (binary files) > $(DESTDIR)/$(SBIN_DIR) where SBIN_DIR=/usr/sbin/dpdk_nic_bind (nic bind > files) > $(DESTDIR)/$(DOC_DIR) where DOC_DIR=/usr/share/doc/dpdk (documentation) > $(DESTDIR)/$(LIB_DIR) (libraries) > if the architecture is 64 bits then LIB_DIR=/usr/lib64 > else LIB_DIR=/usr/lib > $(DESTDIR)/$(KERNEL_DIR) (modules) > if RTE_EXEC_ENV=linuxapp then > KERNEL_DIR=/lib/modules/$(uname -r)/build > else KERNEL_DIR=/boot/modules > All directory variables mentioned above can be overridden. > This hierarchy is based on: > http://www.freedesktop.org/software/systemd/man/file-hierarchy.html > Hmm, I think there's a slight misunderstanding here. What I meant earlier by install-sdk and install-fhs is to preserve the current behavior of "make install" as "make install-sdk" and have "make install-fhs" behave like normal OSS app on "make install", which installs everything (both devel and runtime parts) This patch series eliminates the current behavior of "make install" entirely. I personally would not miss it at all, but there likely are people relying on it since its quite visibly documented and all. So I think the idea was to introduce a separate FHS-installation target and then deal with the notion of default behaviors etc separately. I guess it was already this way in v2 of the series, apologies for missing it there. - Panu -