From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 69091D250
 for <dev@dpdk.org>; Wed, 29 Mar 2017 11:55:01 +0200 (CEST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga104.jf.intel.com with ESMTP; 29 Mar 2017 02:55:00 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,240,1486454400"; d="scan'208";a="82226922"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122])
 ([10.237.220.122])
 by fmsmga006.fm.intel.com with ESMTP; 29 Mar 2017 02:54:59 -0700
To: Ed Czeck <ed.czeck@atomicrules.com>, dev@dpdk.org
References: <1490231015-31748-7-git-send-email-ed.czeck@atomicrules.com>
 <1490749634-1782-1-git-send-email-ed.czeck@atomicrules.com>
Cc: john.miller@atomicrules.com, shepard.siegel@atomicrules.com,
 stephen@networkplumber.org
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <560b3290-2327-f1d9-0e8c-75e3ac19cc47@intel.com>
Date: Wed, 29 Mar 2017 10:54:58 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1490749634-1782-1-git-send-email-ed.czeck@atomicrules.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v6 7/7] net/ark: Arkville PMD component
	integration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Mar 2017 09:55:01 -0000

On 3/29/2017 2:07 AM, Ed Czeck wrote:
> * Flesh out device configuration
> * Add links dev_ops
> * allow dynamic extension loading
> 
> v6:
> * Address review issues
> * Unify messages and logging
> * Improved error capturing
> 
> Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
> Signed-off-by: John Miller <john.miller@atomicrules.com>
> Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>

<...>

> +	/* Setup the packet generator */
> +	if (ark->pkt_gen_args) {
> +		PMD_DRV_LOG(INFO, "Setting up the packet generator\n");
> +		ark_pktgen_parse(ark->pkt_gen_args);
> +		ark_pktgen_reset(ark->pg);
> +		ark_pktgen_setup(ark->pg);
> +		ark->start_pg = 1;
> +	}
> +
> +	/* Setup the packet checker */
> +	if (ark->pkt_chkr_args) {
> +		ark_pktchkr_parse(ark->pkt_chkr_args);
> +		ark_pktchkr_setup(ark->pc);
> +	}

This cause build error [1] with clang, which seems a valid one.

[1]
.../drivers/net/ark/ark_ethdev.c:940:11: error: address of array
'ark->pkt_gen_args' will always evaluate to 'true'
[-Werror,-Wpointer-bool-conversion]
        if (ark->pkt_gen_args) {
        ~~  ~~~~~^~~~~~~~~~~~
.../drivers/net/ark/ark_ethdev.c:949:11: error: address of array
'ark->pkt_chkr_args' will always evaluate to 'true'
[-Werror,-Wpointer-bool-conversion]
        if (ark->pkt_chkr_args) {
        ~~  ~~~~~^~~~~~~~~~~~~