From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D95C43C9F; Wed, 13 Mar 2024 12:19:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B83F640A84; Wed, 13 Mar 2024 12:19:06 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2071.outbound.protection.outlook.com [40.107.244.71]) by mails.dpdk.org (Postfix) with ESMTP id A1A3A402B8 for ; Wed, 13 Mar 2024 12:19:04 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rsk+sBO/F/GBc9faCXaluUYR70OjLvONefnPjKzmB3tFFW9R3H9CewkfT0VGGO6dovwBD2usIXgkaEnyCROiBeelKimNw7NyCPImi31V1SaoXx8Id8mgJEyp4g+ciZaup+9eShtbJ8zkZWMT3vNNg1Ka77jK+I3+9nKhPZKdhp4ysuLU6w181h320r6NLk2wmAKLWozmD84xg6UpzSKtTDyPNlKN3skQmI9h+BjOfua9xfkrjfEOSISyvRDFNDYDVqnrfnMadGgqwvuSpUfTY+r/rxdvbNLvLduff3mHMwhmiJ9OJuTbyESPhZio5EdtzDsTGaI4VzNu41QqAw7suQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xuLEwYnZ6Euw+u9bPXectvWcpIo+HD08I6yhDGc6wV0=; b=VoEoi55I7k3ISwPj/qyGAh3hmFAyuImzON5kZ/eDxXgwUeMyx1AsyzcMVhuGjajGrsCS243yAl+voZ/WMjaJM6MqptAHWvhkmntfQzV9jrbHh1EA9DKzMVjG4Oi7Jv83rEDLQPWRkHNnXfYkq0rbVby28wJAh9yaZGRptseHRJFszLa51O2B/oqyLEMZMAgcn+vkviC2UAGMcCIfzrU73mqhM94phrXkmf8Im/nFfDtRngBluG+17lWriA78XuQDLx5SFa/uQpXULoc09FKlbeI+r8PhZU9vhDVLbpKooBGhshgCxxym0AdZaP6VnS9iAicYDHW2Jw5CmccP8Swp2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xuLEwYnZ6Euw+u9bPXectvWcpIo+HD08I6yhDGc6wV0=; b=Vzdjj5D23DUoM30EZw6rwVtCccOCYAUKjG+0JTaFXpItzHRWOx/2QhZeouhvrljzBilNvnrrhhyVRwNlCvAFDMLQ6ZkY8imwBAmkB3Mj3glTAmx5k7wSKWy/LyPx6QoGcJ752kqlIBfwQnKf41vBpdn7RXxeCOmHTo3fprl6o/s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY5PR12MB6454.namprd12.prod.outlook.com (2603:10b6:930:36::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36; Wed, 13 Mar 2024 11:19:02 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.035; Wed, 13 Mar 2024 11:19:02 +0000 Message-ID: <560e76a6-5d24-42d8-92e1-ed96019dc695@amd.com> Date: Wed, 13 Mar 2024 11:18:56 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/33] net/ena: sub-optimal configuration notifications support Content-Language: en-US To: "Brandes, Shai" Cc: "dev@dpdk.org" References: <20240306122445.4350-1-shaibran@amazon.com> <20240306122445.4350-5-shaibran@amazon.com> <18ee7e3d-ffe9-4cbf-a065-297be214ffa9@amd.com> <93dca30a732f458dbd45610cf0522416@amazon.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <93dca30a732f458dbd45610cf0522416@amazon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P302CA0007.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c2::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY5PR12MB6454:EE_ X-MS-Office365-Filtering-Correlation-Id: 51e2c94f-49af-4af8-698a-08dc434f62fd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g3ypzVFL/cu/pcs3D0YiXlE6/T/jVmGES4zJa/CSWyrAqLTQvoUR9Gs3VhXF4FL5mbV/Z//t2hjHWVEOhQt42cKiUbuY8Cgtpq/KfDMSUN5baTy9nYK6OQOnec5Pp0cDiHucdlrg3e5kfLYadOdmgd+1MWwVqzm2LWxzo5w0K9rlgZF9+Mb3bjiPJV0vaQu3QgXontcZn0fagt3bo4Ywgg2RKhoPq+GgTcrCfBK87cXLDg7VUmwkUT9V2oup6PQfp9cnQswjRpY6A8VeJoG/cl1ATyuhy1q+yWWTRfFeOGAjZchydUzls53F8xZ61OmKjXys1mr9yJWMSwxjwXQD1ModL57GrDC6A8mB28+gIaYyTKPR0Zz778B2QTY7XQ8w0RQChGhqJ1PNESDUdbXE3T+Ai0pBhhe4eZAwbP2yU2lvaXLcPx048Aatcv/+eYRTPVOp9720vNtsNt3drajvwTTv6KXLI2La2nwnReN5EjZ8scUU3aPg8av0Ps77hAk1ZmRtMPKwZAYYohm+e5xaLFeytDnwfjZ/aHF9RYYSyuh9JFH2lS0KSekDJ3MSptjyQKtAsIiIiJOIOIl/LNC8x4s9mI34E7lQD67XDSPxp3CYT22wXokDT9X9mwvgNFvvS3g6CZsaiXUlZFiiAbQTxvFd+gdSuSf1yCs/1+Q+qlU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2tVcFBhemhlNFRheVRRSURxWUw0T3NmbGxFM2pMNFZaV3FQTEhzVzd3bnkw?= =?utf-8?B?aEl1STRBNUxOOVdhUTdYdEpoZkViUW9TNis1ZXRUQkx1b2sxMy9UcjFQcXlS?= =?utf-8?B?RjNxdlNpRTJnV2NjbEZaUkNaQno1ZWU2dUdrZWRpcnFYR2d3S3lIWGNsdEF1?= =?utf-8?B?Z09KVkh3YUFobzhmTjJyTSt5ZTFLV2cwU083cGF1ZTBWMm9jQ3BiUkF1NUJu?= =?utf-8?B?eG10aHlOZDY0RzV3VXZZQldqRGFxanQvK0dTSzZCQ1FVWlpjMzU3ZFFnMWp6?= =?utf-8?B?TVlrQThlVGEzakRoWHcrVVljSmtKN3U5V2JVdGVWUVdQMVBUSVFJTzA4WkNB?= =?utf-8?B?aWVldmM4emt3V3puR3RxUnlLMHlSM3h0Vmd3NXBOQkFHSkZVMW1FWEF0WkFW?= =?utf-8?B?VHMxSmMrckFybWkvQmtKLzg5TXF5YVRyWkZaMGM0UThlZUN6Kzl5cVVUUmlV?= =?utf-8?B?YkcrK1NsM2VHakdrSHZ5R3ZvNVF5K1ZYNkV5eXBxMlBHLzduTzljSFNIZjJQ?= =?utf-8?B?QmdhbjlUNUJJaDl1K0VtRGpuR1dqT29ubE1vVStIb0JDNXFLUEZqd25JMFBm?= =?utf-8?B?S21UYUhOMzEwVURzZm5kMmg0RFA3NDJnT24vbkdodEhrZHFjelY4UUxuYThN?= =?utf-8?B?Zm5PTjNRUlFQdTZseWg5bVlVTmZEdmNjMlVleTBOYTdkdTF2eVRGejdCOUpm?= =?utf-8?B?ZE5mdXl4WDlpQWdXb3RuNVdNT3MwQmhNaDJ6Nm1jL1VKZU1UQmI5cjMyemlY?= =?utf-8?B?QjFPaExFWFBJNUFySU1kWG9iSW51QURYWHpCVGVTVmZuNjdnMDB1MnFmS1lL?= =?utf-8?B?TmQ0dVc1aVBTaFhTOEN4THlRL3R2VmVTdFN2bVdxMnRvYjBJRXZ6SXJ3cDJS?= =?utf-8?B?a3hGam9qY20yVm0weFJaSGg0Mmc1cEJMVTlUZmxKVDAxWVMxNHFSNDJNajFn?= =?utf-8?B?djVYcWViQWdtdTRLaStxOEZoZFJjYkIyQm1CTXlneExQNUM2aXBIVUJibFZm?= =?utf-8?B?NDZOSCtvaHhLRlpreUc3MW1rZUp5ZWFYR3ZGTUx6Qmpxcmtid3cxMG5FSEdS?= =?utf-8?B?UDg5K0lQcnZnTkpRajRRcEkvTTNWdmw2UHhqWmFXSXZqRW5tVG1lVU53eVMx?= =?utf-8?B?U0JyK1cydHVFTmUyVjF6NGdoU2RXZzRITXBpUGMrVlZyQ2p3anNTaUM0Y1Qv?= =?utf-8?B?Nm00dXJCNFZCK21FN3Nyc2JqS2YyNXdqbFlkcHdjTkl6MDlSalZxMXBuYVZL?= =?utf-8?B?NUl2SmhRWHZtUnhMRW5nb3k1UlRFNHcxRWdYTG1sb1YxaHVMNkZuVkJ6QUoz?= =?utf-8?B?dnFIZUl6M1ZaNVdNdGJ2SUhHazk1aGNaYVhZLzFXcHQxazN3NGhmQW1Nb2da?= =?utf-8?B?M0NoV1V4aG1MMTdreUIrRzhaNGxSc2MyQ3U2VUlCRU45ejVOd2FqWDNBZGhF?= =?utf-8?B?eHI5SzB5YS9HOXcwOFoxMS9rOC95cXNvNlowSUtTSDRYMmtiV0NnKzh2WUJi?= =?utf-8?B?dmhOeEtUMGN0cytKVkt3d2dVbDV4SDU4Nk56K2FSeDRiMkk0NzE0MnFSeTRQ?= =?utf-8?B?cVdVb3RldXpUUGFZMXE1WGdOU3o3VXlxWkxnWGJ4bmdZWHhFbi9QakRjRjcz?= =?utf-8?B?K1I2RWZBOThlNVNOWFZCMlE0SjUwQ0hYdExVOFY4VFgzR1R6TC9vZzlZbjdG?= =?utf-8?B?L1BRTGY5UUhIU0p6WW1ObmEra3M2L1p2NEFRdnRDTWN3Rk5jOTJxV0FROXBw?= =?utf-8?B?RGhyWGVmYVpVandjMm5RTzBsbVdLb0UyK3VGSUJ2QkhkR3pMd2gvdTZjT3dz?= =?utf-8?B?dnZUdVAxdTBYWXdWNktHOTdJc1NWVDJpODlxdlRsSlFQL0I0ZlM2QkdZQ1Ar?= =?utf-8?B?OTg3Y0t6MWljeS9DREdaRFFTdkNPdkp4MDN0Y2NudWxadlRvZXFXN3VxbVpp?= =?utf-8?B?anZBVnhxVm5HcTZQcktyL3BFaHc0UFdDUWpiVFlVUGIvL21KcnZ3UXZtMFJp?= =?utf-8?B?bTl2VUt2U0VlQlNraVRRV0k5TENwdXRJd1pIWXU3SHpJQzJqaVVQSHk0b0hw?= =?utf-8?B?RDVqeWpmeHlVTHlSOWJGV2N1TXhCdS96UmRraDVSRnZjR2hmMGthRi9pc3pp?= =?utf-8?Q?QzCi+rVdiQPSecHoX/FNW3gV+?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51e2c94f-49af-4af8-698a-08dc434f62fd X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 11:19:02.5176 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3Zx9UrcKy2b+6ypi5SSHRFvvS3d1z1Hcop41AKCtBfnE7tSKZnmufJ7LdYWCJ8Yz X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6454 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/10/2024 2:43 PM, Brandes, Shai wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Friday, March 8, 2024 7:23 PM >> To: Brandes, Shai >> Cc: dev@dpdk.org >> Subject: RE: [EXTERNAL] [PATCH v3 04/33] net/ena: sub-optimal >> configuration notifications support >> >> CAUTION: This email originated from outside of the organization. Do not click >> links or open attachments unless you can confirm the sender and know the >> content is safe. >> >> >> >> On 3/6/2024 12:24 PM, shaibran@amazon.com wrote: >>> From: Shai Brandes >>> >>> ENA device will send asynchronous notifications to the driver in order >>> to notify users about sub-optimal configurations and refer them to >>> public AWS documentation for further action. >>> >> >> Hi Shai, >> >> This is an interesting feature, I am curious, is there more public detail >> provided by AWS on how it detects sub-optimal configuration and what are >> the possible types of the notifications? >> > [Brandes, Shai] This is only a framework to allow notifications to the user. Currently, the only notification the device supports relate to sub-optimal configuration when enabling ena-express feature. > The public documentation for it was not published yet, but it currently contains only two codes, indicating the user that it is better to run with normal-llq when working with ena-express and an option to increase the Tx queue depth when working with ena-express to double the default size on specific hardwares that have a larger bar (known only in run-time) > Thanks for the info. When there is a public documentation for the feature, can you please reference it from driver documentation? > >>> Signed-off-by: Shai Brandes >>> Reviewed-by: Amit Bernstein >>> --- >>> doc/guides/rel_notes/release_24_03.rst | 1 + >>> .../net/ena/base/ena_defs/ena_admin_defs.h | 11 +++++++- >>> drivers/net/ena/ena_ethdev.c | 26 +++++++++++++++++-- >>> 3 files changed, 35 insertions(+), 3 deletions(-) >>> >>> diff --git a/doc/guides/rel_notes/release_24_03.rst >>> b/doc/guides/rel_notes/release_24_03.rst >>> index fb66d67d32..f47073c7dc 100644 >>> --- a/doc/guides/rel_notes/release_24_03.rst >>> +++ b/doc/guides/rel_notes/release_24_03.rst >>> @@ -104,6 +104,7 @@ New Features >>> * **Updated Amazon ena (Elastic Network Adapter) net driver.** >>> >>> * Removed the reporting of `rx_overruns` errors from xstats and instead >> updated `imissed` stat with its value. >>> + * Added support for sub-optimal configuration notifications from the >> device. >>> >>> * **Updated Atomic Rules' Arkville driver.** >>> >>> diff --git a/drivers/net/ena/base/ena_defs/ena_admin_defs.h >>> b/drivers/net/ena/base/ena_defs/ena_admin_defs.h >>> index fa43e22918..4172916551 100644 >>> --- a/drivers/net/ena/base/ena_defs/ena_admin_defs.h >>> +++ b/drivers/net/ena/base/ena_defs/ena_admin_defs.h >>> @@ -1214,7 +1214,8 @@ enum ena_admin_aenq_group { >>> ENA_ADMIN_NOTIFICATION = 3, >>> ENA_ADMIN_KEEP_ALIVE = 4, >>> ENA_ADMIN_REFRESH_CAPABILITIES = 5, >>> - ENA_ADMIN_AENQ_GROUPS_NUM = 6, >>> + ENA_ADMIN_CONF_NOTIFICATIONS = 6, >>> + ENA_ADMIN_AENQ_GROUPS_NUM = 7, >>> }; >>> >>> enum ena_admin_aenq_notification_syndrome { @@ -1251,6 +1252,14 >> @@ >>> struct ena_admin_aenq_keep_alive_desc { >>> uint32_t rx_overruns_high; >>> }; >>> >>> +struct ena_admin_aenq_conf_notifications_desc { >>> + struct ena_admin_aenq_common_desc aenq_common_desc; >>> + >>> + uint64_t notifications_bitmap; >>> + >>> + uint64_t reserved; >>> +}; >>> + >>> struct ena_admin_ena_mmio_req_read_less_resp { >>> uint16_t req_id; >>> >>> diff --git a/drivers/net/ena/ena_ethdev.c >>> b/drivers/net/ena/ena_ethdev.c index d3f395a832..3157237c0d 100644 >>> --- a/drivers/net/ena/ena_ethdev.c >>> +++ b/drivers/net/ena/ena_ethdev.c >>> @@ -36,6 +36,10 @@ >>> >>> #define ENA_MIN_RING_DESC 128 >>> >>> +#define BITS_PER_BYTE 8 >>> + >>> +#define BITS_PER_TYPE(type) (sizeof(type) * BITS_PER_BYTE) >>> + >>> >> >> 'CHAR_BIT' macro can be used here, but I can see there are multiple drivers >> defining similar macros.So no need to update this patch, but to record that >> this is something to address DPDK wide. >> >> If ena team volunteers to tackle this update, it is welcomed ;) > [Brandes, Shai] sure, can be done > Thanks, appreciated.