From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Rongwei Liu <rongweil@nvidia.com>,
dev@dpdk.org, matan@nvidia.com, viacheslavo@nvidia.com,
orika@nvidia.com, suanmingm@nvidia.com, thomas@monjalon.net
Cc: Dariusz Sosnowski <dsosnowski@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH v8 2/3] ethdev: add VXLAN last reserved field
Date: Tue, 11 Jun 2024 15:52:48 +0100 [thread overview]
Message-ID: <560e87e1-30ec-424b-bd88-19ef2a6ce057@amd.com> (raw)
In-Reply-To: <20240607140208.315235-3-rongweil@nvidia.com>
On 6/7/2024 3:02 PM, Rongwei Liu wrote:
> diff --git a/lib/net/rte_vxlan.h b/lib/net/rte_vxlan.h
> index 997fc784fc..57300fb442 100644
> --- a/lib/net/rte_vxlan.h
> +++ b/lib/net/rte_vxlan.h
> @@ -41,7 +41,10 @@ struct rte_vxlan_hdr {
> uint8_t flags; /**< Should be 8 (I flag). */
> uint8_t rsvd0[3]; /**< Reserved. */
> uint8_t vni[3]; /**< VXLAN identifier. */
> - uint8_t rsvd1; /**< Reserved. */
> + union {
> + uint8_t rsvd1; /**< Reserved. */
> + uint8_t last_rsvd; /**< Reserved. */
> + };
>
Is there a plan to remove 'rsvd1' in next ABI break release?
We can keep both, but I guess it is not logically necessary to keep it,
to prevent bloat by time, we can remove the old one.
If decided to remove, sending a 'deprecation.rst' update helps us to
remember doing it.
next prev parent reply other threads:[~2024-06-11 14:52 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 7:28 [PATCH v1 0/3] support VXLAN rsvd1 modification Rongwei Liu
2024-05-23 7:28 ` [PATCH v1 1/3] ethdev: add VXLAN last reserved field Rongwei Liu
2024-05-23 7:28 ` [PATCH v1 2/3] app/testpmd: add VXLAN last reserved modification command Rongwei Liu
2024-05-24 15:53 ` Dariusz Sosnowski
2024-05-27 2:47 ` [PATCH v2 0/4] support VXLAN rsvd1 modification Rongwei Liu
2024-05-27 2:47 ` [PATCH v2 1/4] app/testpmd: fix the testpmd field string sequence Rongwei Liu
2024-05-30 8:22 ` rongwei liu
2024-06-03 7:30 ` Dariusz Sosnowski
2024-05-27 2:47 ` [PATCH v2 2/4] ethdev: add VXLAN last reserved field Rongwei Liu
2024-06-04 11:27 ` rongwei liu
2024-06-04 11:59 ` Thomas Monjalon
2024-06-04 12:06 ` rongwei liu
2024-06-04 12:14 ` [PATCH v3 0/3] support VXLAN rsvd1 modification Rongwei Liu
2024-06-04 12:15 ` [PATCH v3 1/3] app/testpmd: fix the testpmd field string sequence Rongwei Liu
2024-06-04 12:15 ` [PATCH v3 2/3] ethdev: add VXLAN last reserved field Rongwei Liu
2024-06-04 12:15 ` [PATCH v3 3/3] net/mlx5: implement VXLAN last reserved modification Rongwei Liu
2024-05-27 2:47 ` [PATCH v2 3/4] app/testpmd: add VXLAN last reserved modification command Rongwei Liu
2024-06-04 12:00 ` Thomas Monjalon
2024-05-27 2:47 ` [PATCH v2 4/4] net/mlx5: implement VXLAN last reserved modification Rongwei Liu
2024-06-04 12:19 ` Thomas Monjalon
2024-06-04 12:24 ` rongwei liu
2024-06-04 12:38 ` [PATCH v4 0/3] support VXLAN rsvd1 modification Rongwei Liu
2024-06-04 12:38 ` [PATCH v4 1/3] app/testpmd: fix the testpmd field string sequence Rongwei Liu
2024-06-04 12:38 ` [PATCH v4 2/3] ethdev: add VXLAN last reserved field Rongwei Liu
2024-06-04 15:03 ` Thomas Monjalon
2024-06-04 16:29 ` rongwei liu
2024-06-04 16:40 ` Dariusz Sosnowski
2024-06-04 18:37 ` Thomas Monjalon
2024-06-05 1:16 ` rongwei liu
2024-06-05 7:13 ` Thomas Monjalon
2024-06-05 8:14 ` rongwei liu
2024-06-05 9:35 ` Thomas Monjalon
2024-06-05 9:41 ` rongwei liu
2024-06-05 9:53 ` Thomas Monjalon
2024-06-05 10:21 ` [PATCH v6 0/4] support VXLAN last reserved byte modification Rongwei Liu
2024-06-05 10:21 ` [PATCH v6 1/4] app/testpmd: fix the testpmd field string sequence Rongwei Liu
2024-06-09 14:29 ` Ori Kam
2024-06-05 10:21 ` [PATCH v6 2/4] net: add new union into VXLAN header Rongwei Liu
2024-06-05 10:42 ` Thomas Monjalon
2024-06-05 11:28 ` rongwei liu
2024-06-05 12:14 ` Thomas Monjalon
2024-06-05 13:04 ` [PATCH v7 0/3] support VXLAN last reserved byte modification Rongwei Liu
2024-06-05 13:04 ` [PATCH v7 1/3] app/testpmd: fix the testpmd field string sequence Rongwei Liu
2024-06-05 13:04 ` [PATCH v7 2/3] ethdev: add VXLAN last reserved field Rongwei Liu
2024-06-07 13:25 ` Thomas Monjalon
2024-06-07 13:55 ` rongwei liu
2024-06-07 14:02 ` [PATCH v8 0/3] support VXLAN last reserved byte modification Rongwei Liu
2024-06-07 14:02 ` [PATCH v8 1/3] app/testpmd: fix the testpmd field string sequence Rongwei Liu
2024-06-11 6:59 ` Ori Kam
2024-06-11 14:52 ` Ferruh Yigit
2024-06-07 14:02 ` [PATCH v8 2/3] ethdev: add VXLAN last reserved field Rongwei Liu
2024-06-09 10:32 ` Thomas Monjalon
2024-06-11 14:52 ` Ferruh Yigit [this message]
2024-06-12 1:25 ` rongwei liu
2024-06-25 14:46 ` Thomas Monjalon
2024-06-07 14:02 ` [PATCH v8 3/3] net/mlx5: implement VXLAN last reserved modification Rongwei Liu
2024-06-11 14:52 ` [PATCH v8 0/3] support VXLAN last reserved byte modification Ferruh Yigit
2024-06-05 13:04 ` [PATCH v7 3/3] net/mlx5: implement VXLAN last reserved modification Rongwei Liu
2024-06-05 10:21 ` [PATCH v6 3/4] ethdev: add VXLAN last reserved field Rongwei Liu
2024-06-05 10:21 ` [PATCH v6 4/4] net/mlx5: implement VXLAN last reserved modification Rongwei Liu
2024-06-05 8:41 ` [PATCH v5 0/3] support VXLAN last reserved byte modification Rongwei Liu
2024-06-05 8:41 ` [PATCH v5 1/3] app/testpmd: fix the testpmd field string sequence Rongwei Liu
2024-06-05 8:41 ` [PATCH v5 2/3] ethdev: add VXLAN last reserved field Rongwei Liu
2024-06-05 8:41 ` [PATCH v5 3/3] net/mlx5: implement VXLAN last reserved modification Rongwei Liu
2024-06-04 12:38 ` [PATCH v4 " Rongwei Liu
2024-05-27 2:56 ` [PATCH v1 2/3] app/testpmd: add VXLAN last reserved modification command rongwei liu
2024-05-23 7:28 ` [PATCH v1 3/3] net/mlx5: implement VXLAN last reserved modification Rongwei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560e87e1-30ec-424b-bd88-19ef2a6ce057@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rongweil@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).