From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 217951B1D8 for ; Tue, 13 Feb 2018 10:22:27 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2018 01:22:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,507,1511856000"; d="scan'208";a="26887143" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by FMSMGA003.fm.intel.com with ESMTP; 13 Feb 2018 01:22:26 -0800 Received: from pgsmsx102.gar.corp.intel.com ([169.254.6.149]) by KMSMSX153.gar.corp.intel.com ([169.254.5.52]) with mapi id 14.03.0319.002; Tue, 13 Feb 2018 17:22:25 +0800 From: "Gujjar, Abhinandan S" To: "Doherty, Declan" , "akhil.goyal@nxp.com" , "De Lara Guarch, Pablo" , "Jerin.JacobKollanukkaran@cavium.com" CC: "dev@dpdk.org" , "Vangati, Narender" , "Rao, Nikhil" Thread-Topic: [RFC v3, 1/3] cryptodev: set private data for session-less mode Thread-Index: AQHTmz9opcrE6WL2OUK6j7btSqnUgqOiIcNQ Date: Tue, 13 Feb 2018 09:22:24 +0000 Message-ID: <5612CB344B05EE4F95FC5B729939F7807063A287@PGSMSX102.gar.corp.intel.com> References: <1517477405-169206-1-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: <1517477405-169206-1-git-send-email-abhinandan.gujjar@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzAzOTgxN2QtNGRlMi00ZDdhLWE3NjQtMWU1NjkwNDMzNjUzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImdmV0E1bnhIdUVuZnNRMWY1Y3lPXC9vRFhVSlh5V2ZrYnc3cmtWK0hNbURRPSJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC v3, 1/3] cryptodev: set private data for session-less mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 09:22:28 -0000 A gentle remainder for review :) -Abhinandan > -----Original Message----- > From: Gujjar, Abhinandan S > Sent: Thursday, February 1, 2018 3:00 PM > To: Doherty, Declan ; akhil.goyal@nxp.com; De > Lara Guarch, Pablo ; > Jerin.JacobKollanukkaran@cavium.com > Cc: dev@dpdk.org; Vangati, Narender ; Gujjar, > Abhinandan S ; Rao, Nikhil > > Subject: [RFC v3, 1/3] cryptodev: set private data for session-less mode >=20 > The application may want to store private data along with the rte_crypto_= op > that is transparent to the rte_cryptodev layer. > For e.g., If an eventdev based application is submitting a crypto session= -less > operation and wants to indicate event information required to construct a= new > event that will be enqueued to eventdev after completion of the crypto > operation. This patch provides a mechanism for the application to associa= te this > information with the rte_crypto_op in session-less mode. >=20 > Signed-off-by: Abhinandan Gujjar > Signed-off-by: Nikhil Rao > --- > Notes: > V3: > 1. Added separate patch for session-less private data > 2. Added more information on offset > V2: > 1. Removed enum rte_crypto_op_private_data_type > 2. Corrected formatting >=20 > lib/librte_cryptodev/rte_crypto.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git a/lib/librte_cryptodev/rte_crypto.h b/lib/librte_cryptodev/rte= _crypto.h > index 95cf861..2540426 100644 > --- a/lib/librte_cryptodev/rte_crypto.h > +++ b/lib/librte_cryptodev/rte_crypto.h > @@ -84,8 +84,14 @@ struct rte_crypto_op { > */ > uint8_t sess_type; > /**< operation session type */ > + uint16_t private_data_offset; > + /**< Offset to indicate start of private data (if any). The offset > + * is counted from the start of the rte_crypto_op including IV. > + * The private data may be used by the application to store > + * information which should remain untouched in the library/driver > + */ >=20 > - uint8_t reserved[5]; > + uint8_t reserved[3]; > /**< Reserved bytes to fill 64 bits for future additions */ > struct rte_mempool *mempool; > /**< crypto operation mempool which operation is allocated from */ > -- > 1.9.1