From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id BC86B1B2C0 for ; Tue, 13 Feb 2018 17:10:24 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2018 08:10:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,507,1511856000"; d="scan'208";a="17344401" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga007.jf.intel.com with ESMTP; 13 Feb 2018 08:10:22 -0800 Received: from pgsmsx102.gar.corp.intel.com ([169.254.6.149]) by PGSMSX101.gar.corp.intel.com ([169.254.1.181]) with mapi id 14.03.0319.002; Wed, 14 Feb 2018 00:10:21 +0800 From: "Gujjar, Abhinandan S" To: "De Lara Guarch, Pablo" , "Doherty, Declan" , "akhil.goyal@nxp.com" , "Jerin.JacobKollanukkaran@cavium.com" CC: "dev@dpdk.org" , "Vangati, Narender" , "Rao, Nikhil" Thread-Topic: [RFC v3, 1/3] cryptodev: set private data for session-less mode Thread-Index: AQHTmz9opcrE6WL2OUK6j7btSqnUgqOh+EUAgACa8vA= Date: Tue, 13 Feb 2018 16:10:20 +0000 Message-ID: <5612CB344B05EE4F95FC5B729939F7807063A76B@PGSMSX102.gar.corp.intel.com> References: <1517477405-169206-1-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjhiMzk0MzktMGY0ZC00NDEyLWE2ODEtODgyZjczYzMxNjZlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InFuR1JcL3RmZGpXaVhwazFwWFB4enp1MWQycFg4bXZjN3hjelZldGtWNEw0PSJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC v3, 1/3] cryptodev: set private data for session-less mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 16:10:25 -0000 Hi Pablo, > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Tuesday, February 13, 2018 8:24 PM > To: Gujjar, Abhinandan S ; Doherty, Declan > ; akhil.goyal@nxp.com; > Jerin.JacobKollanukkaran@cavium.com > Cc: dev@dpdk.org; Vangati, Narender ; Rao, > Nikhil > Subject: RE: [RFC v3, 1/3] cryptodev: set private data for session-less m= ode >=20 > Hi, >=20 > > -----Original Message----- > > From: Gujjar, Abhinandan S > > Sent: Thursday, February 1, 2018 9:30 AM > > To: Doherty, Declan ; akhil.goyal@nxp.com; > > De Lara Guarch, Pablo ; > > Jerin.JacobKollanukkaran@cavium.com > > Cc: dev@dpdk.org; Vangati, Narender ; > > Gujjar, Abhinandan S ; Rao, Nikhil > > > > Subject: [RFC v3, 1/3] cryptodev: set private data for session-less > > mode > > > > The application may want to store private data along with the > > rte_crypto_op that is transparent to the rte_cryptodev layer. > > For e.g., If an eventdev based application is submitting a crypto > > session-less operation and wants to indicate event information > > required to construct a new event that will be enqueued to eventdev > > after completion of the crypto operation. This patch provides a > > mechanism for the application to associate this information with the > rte_crypto_op in session-less mode. > > > > Signed-off-by: Abhinandan Gujjar > > Signed-off-by: Nikhil Rao > > --- > > Notes: > > V3: > > 1. Added separate patch for session-less private data > > 2. Added more information on offset > > V2: > > 1. Removed enum rte_crypto_op_private_data_type > > 2. Corrected formatting > > > > lib/librte_cryptodev/rte_crypto.h | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/lib/librte_cryptodev/rte_crypto.h > > b/lib/librte_cryptodev/rte_crypto.h > > index 95cf861..2540426 100644 > > --- a/lib/librte_cryptodev/rte_crypto.h > > +++ b/lib/librte_cryptodev/rte_crypto.h > > @@ -84,8 +84,14 @@ struct rte_crypto_op { > > */ > > uint8_t sess_type; > > /**< operation session type */ > > + uint16_t private_data_offset; > > + /**< Offset to indicate start of private data (if any). The offset > > + * is counted from the start of the rte_crypto_op including IV. >=20 > I assume that if this offset is 0, it means that there is no private data= ? Yes >=20 > Also, I would reword the Doxygen comment a bit (here is my suggestion, wh= ich > looks a bit long, but I hope it is descriptive). >=20 > " Offset to indicate start of private data (if any). The offset is counte= d from the > start of the rte_crypto_op structure. > The private data may be used by the application to store information whic= h > should remain untouched in the library/driver. > Note that an Initialization Vector (IV) for the operation may be placed a= t the end > of the structure as well, so caution to avoid overwrites has to be taken.= " >=20 >=20 > > + * The private data may be used by the application to store > > + * information which should remain untouched in the library/driver > > + */ > > > > - uint8_t reserved[5]; > > + uint8_t reserved[3]; > > /**< Reserved bytes to fill 64 bits for future additions */ > > struct rte_mempool *mempool; > > /**< crypto operation mempool which operation is allocated from */ > > -- > > 1.9.1 >=20 > Apart from the comments above, this overall looks good to me. > I would say you could submit a v1 with some implementation. Ok. > Could you also modify the Cryptodev section in the Programmer's Guide > document, to reflect these changes? Sure. Thanks Abhinandan >=20 > Thanks, > Pablo