From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9336ECFFE for ; Mon, 16 Apr 2018 11:36:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2018 02:36:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,459,1517904000"; d="scan'208";a="43640626" Received: from kmsmsx154.gar.corp.intel.com ([172.21.73.14]) by orsmga003.jf.intel.com with ESMTP; 16 Apr 2018 02:36:26 -0700 Received: from pgsmsx102.gar.corp.intel.com ([169.254.6.99]) by KMSMSX154.gar.corp.intel.com ([169.254.12.35]) with mapi id 14.03.0319.002; Mon, 16 Apr 2018 17:36:25 +0800 From: "Gujjar, Abhinandan S" To: Akhil Goyal , "De Lara Guarch, Pablo" , "Doherty, Declan" , "jerin.jacob@caviumnetworks.com" , "hemant.agrawal@nxp.com" , "dev@dpdk.org" CC: "Vangati, Narender" , "Rao, Nikhil" Thread-Topic: [v3,3/3] doc: add private data info in crypto guide Thread-Index: AQHT1U/OxFaN6ls4sE2/14VhgjrHzqQClpWAgACI7bA= Date: Mon, 16 Apr 2018 09:36:24 +0000 Message-ID: <5612CB344B05EE4F95FC5B729939F780706E4CB4@PGSMSX102.gar.corp.intel.com> References: <1523861696-103397-1-git-send-email-abhinandan.gujjar@intel.com> <1523861696-103397-3-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWUxYzNlMGQtN2VhMy00N2Y0LThkNzItMGZhNjcxYjQ3MjM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InNPWE1kU1Q3bjdmY0tpK1dYNlZYUGI3NzRveWdyZWVHNXl4N1BrcGljaDg9In0= dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [v3,3/3] doc: add private data info in crypto guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 09:36:30 -0000 Hi Akhil, Missed out the *series* and thought the ack was only on the doc patch. Regarding change log, Just before posting I looked at recent patches. Most of them, didn't have change log! So, I didn't add it. Yes, there is a typo in the subject of this patch. Does this require newer = version of patches? Regards Abhinandan > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Monday, April 16, 2018 2:47 PM > To: Gujjar, Abhinandan S ; De Lara Guarch, P= ablo > ; Doherty, Declan > ; jerin.jacob@caviumnetworks.com; > hemant.agrawal@nxp.com; dev@dpdk.org > Cc: Vangati, Narender ; Rao, Nikhil > > Subject: Re: [v3,3/3] doc: add private data info in crypto guide >=20 > Hi Abhinandan, >=20 > On 4/16/2018 12:24 PM, Abhinandan Gujjar wrote: > > Signed-off-by: Abhinandan Gujjar > > Acked-by: Akhil Goyal > I think I acked this complete series. And this patch is v2 not v3. You sh= ould also > mention the changelog. >=20 > Thanks, > Akhil >=20 > > --- > > doc/guides/prog_guide/cryptodev_lib.rst | 27 > > +++++++++++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > > > diff --git a/doc/guides/prog_guide/cryptodev_lib.rst > > b/doc/guides/prog_guide/cryptodev_lib.rst > > index 066fe2d..b279a20 100644 > > --- a/doc/guides/prog_guide/cryptodev_lib.rst > > +++ b/doc/guides/prog_guide/cryptodev_lib.rst > > @@ -299,6 +299,33 @@ directly from the devices processed queue, and > > for virtual device's from a enqueue call. > > > > > > +Private data > > +~~~~~~~~~~~~ > > +For session-based operations, the set and get API provides a > > +mechanism for an application to store and retrieve the private data > > +information stored along with the crypto session. > > + > > +For example, suppose an application is submitting a crypto operation > > +with a session associated and wants to indicate private data > > +information which is required to be used after completion of the > > +crypto operation. In this case, the application can use the set API to= set the > private data and retrieve it using get API. > > + > > +.. code-block:: c > > + > > + int rte_cryptodev_sym_session_set_private_data( > > + struct rte_cryptodev_sym_session *sess, void *data, uint16_t > size); > > + > > + void * rte_cryptodev_sym_session_get_private_data( > > + struct rte_cryptodev_sym_session *sess); > > + > > + > > +For session-less mode, the private data information can be placed > > +along with the ``struct rte_crypto_op``. The > > +``rte_crypto_op::private_data_offset`` indicates the start of private > > +data information. The offset is counted from the start of the > > +rte_crypto_op including other crypto information such as the IVs (sinc= e there > can be an IV also for authentication). > > + > > + > > Enqueue / Dequeue Burst APIs > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > >