From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 82192569B for ; Thu, 26 Apr 2018 08:20:15 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2018 23:20:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,329,1520924400"; d="scan'208";a="223459952" Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103]) by fmsmga005.fm.intel.com with ESMTP; 25 Apr 2018 23:20:12 -0700 Received: from pgsmsx109.gar.corp.intel.com (10.221.44.109) by PGSMSX108.gar.corp.intel.com (10.221.44.103) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 26 Apr 2018 14:20:11 +0800 Received: from pgsmsx102.gar.corp.intel.com ([169.254.6.245]) by PGSMSX109.gar.corp.intel.com ([169.254.14.58]) with mapi id 14.03.0319.002; Thu, 26 Apr 2018 14:20:11 +0800 From: "Gujjar, Abhinandan S" To: Akhil Goyal , "jerin.jacob@caviumnetworks.com" , "hemant.agrawal@nxp.com" , "dev@dpdk.org" CC: "Vangati, Narender" , "Rao, Nikhil" , "Eads, Gage" Thread-Topic: [dpdk-dev] [v2,3/6] eventdev: add crypto adapter implementation Thread-Index: AQHT28nkP/Ti+L5nqUKVBBotSI+yAKQRAZ8AgAGT5IA= Date: Thu, 26 Apr 2018 06:20:11 +0000 Message-ID: <5612CB344B05EE4F95FC5B729939F780706FFA42@PGSMSX102.gar.corp.intel.com> References: <1524573807-168522-1-git-send-email-abhinandan.gujjar@intel.com> <1524573807-168522-4-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjI1YjczMDctMWM5Ny00YzE3LTg1OTgtYjgzZDUzNmI4YzMzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlF3N25UUkJFZTZVUTlFNnpIQXdPc2gzUmk0bkZZanpocHVBZVRHeGtyMHM9In0= dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [v2, 3/6] eventdev: add crypto adapter implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 06:20:16 -0000 Hi Akhil, > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Wednesday, April 25, 2018 7:44 PM > To: Gujjar, Abhinandan S ; > jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com; > akhil.goyal@nxp.com; dev@dpdk.org > Cc: Vangati, Narender ; Rao, Nikhil > ; Eads, Gage > Subject: Re: [dpdk-dev] [v2,3/6] eventdev: add crypto adapter implementat= ion >=20 > On 4/24/2018 6:13 PM, Abhinandan Gujjar wrote: > > Signed-off-by: Abhinandan Gujjar > > Signed-off-by: Nikhil Rao > > Signed-off-by: Gage Eads > > --- >=20 > [snip..] > > +int __rte_experimental > > +rte_event_crypto_adapter_start(uint8_t id) { > > + struct rte_event_crypto_adapter *adapter; > > + > > + RTE_EVENT_CRYPTO_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL); > > + adapter =3D eca_id_to_adapter(id); > > + if (adapter =3D=3D NULL) > > + return -EINVAL; > This check is redundant here. you are null checking it again in eca_adapt= er_ctrl Ok. > > + > > + return eca_adapter_ctrl(id, 1); > > +} > > + > > +int __rte_experimental > > +rte_event_crypto_adapter_stop(uint8_t id) { > > + return eca_adapter_ctrl(id, 0); > > +} > > + >=20 > [snip..] > > diff --git a/lib/librte_eventdev/rte_eventdev_version.map > > b/lib/librte_eventdev/rte_eventdev_version.map > > index 3ee28f7..774f7c5 100644 > > --- a/lib/librte_eventdev/rte_eventdev_version.map > > +++ b/lib/librte_eventdev/rte_eventdev_version.map > > @@ -72,6 +72,18 @@ DPDK_18.02 { > > global: > > > > rte_event_dev_selftest; > > + rte_event_crypto_adapter_create_ext; > > + rte_event_crypto_adapter_create; > > + rte_event_crypto_adapter_free; > > + rte_event_crypto_adapter_queue_pair_add; > > + rte_event_crypto_adapter_queue_pair_del; > > + rte_event_crypto_adapter_start; > > + rte_event_crypto_adapter_stop; > > + rte_event_crypto_adapter_stats_get; > > + rte_event_crypto_adapter_stats_reset; > > + rte_event_crypto_adapter_service_id_get; > > + rte_event_crypto_adapter_event_port_get; > > + > I believe these shall go in EXPERIMENTAL along with timer. Ok > > } DPDK_17.11; > > > > DPDK_18.05 { > >