From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18177A0353; Tue, 19 Nov 2019 11:36:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 85D7BCF3; Tue, 19 Nov 2019 11:36:11 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 13CCC1F5 for ; Tue, 19 Nov 2019 11:36:09 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Nov 2019 02:36:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,322,1569308400"; d="scan'208";a="357073524" Received: from pgsmsx113.gar.corp.intel.com ([10.108.55.202]) by orsmga004.jf.intel.com with ESMTP; 19 Nov 2019 02:36:07 -0800 Received: from pgsmsx110.gar.corp.intel.com (10.221.44.111) by pgsmsx113.gar.corp.intel.com (10.108.55.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 Nov 2019 18:36:06 +0800 Received: from pgsmsx102.gar.corp.intel.com ([169.254.6.64]) by PGSMSX110.gar.corp.intel.com ([10.221.44.111]) with mapi id 14.03.0439.000; Tue, 19 Nov 2019 18:36:06 +0800 From: "Gujjar, Abhinandan S" To: Hemant Agrawal , "dev@dpdk.org" CC: "jerinjacobk@gmail.com" Thread-Topic: [PATCH v2 1/3] test/event_crypto: fix missing IV value for AES algo Thread-Index: AQHVlUplqzWmMsBYXECJZjAy+pRNFqeSXkGA Date: Tue, 19 Nov 2019 10:36:05 +0000 Message-ID: <5612CB344B05EE4F95FC5B729939F780795E3E51@PGSMSX102.gar.corp.intel.com> References: <20191001113339.21767-1-hemant.agrawal@nxp.com> <20191107090121.3246-1-hemant.agrawal@nxp.com> In-Reply-To: <20191107090121.3246-1-hemant.agrawal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWZmZTUyOGItOGRjZi00NmRkLTk5MmItYWY3NzIzMjFhN2NiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiY3JNTTgxN1BDbmJYUHp5ZnFxU0NJOWZEVEZ3dGlKdXhvWUZFRGMzVTNxcndsMkVBWnUrYjlSVVdVeVdDRzd3YSJ9 dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/3] test/event_crypto: fix missing IV value for AES algo X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" For series: Acked-by: abhinandan.gujjar@intel.com I noticed that these patches have issue with "Intel-compilation". Hope, it will be taken care before merging.=20 > -----Original Message----- > From: Hemant Agrawal > Sent: Thursday, November 7, 2019 2:31 PM > To: dev@dpdk.org > Cc: jerinjacobk@gmail.com; Gujjar, Abhinandan S > > Subject: [PATCH v2 1/3] test/event_crypto: fix missing IV value for AES a= lgo >=20 > The IV was not set, which was causing HW based SEC on DPAA1 to fail. >=20 > Fixes: ce02103ad072 ("test/event_crypto: change the SEC cipher algo") >=20 > Signed-off-by: Hemant Agrawal > --- > Sending only the fixes. dropped the functional changes >=20 > app/test/test_event_crypto_adapter.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/app/test/test_event_crypto_adapter.c > b/app/test/test_event_crypto_adapter.c > index 652e458f0..bf83a6357 100644 > --- a/app/test/test_event_crypto_adapter.c > +++ b/app/test/test_event_crypto_adapter.c > @@ -171,6 +171,7 @@ test_op_forward_mode(uint8_t session_less) > struct rte_event ev; > uint32_t cap; > int ret; > + uint8_t cipher_key[17]; >=20 > memset(&m_data, 0, sizeof(m_data)); >=20 > @@ -186,6 +187,11 @@ test_op_forward_mode(uint8_t session_less) > cipher_xform.cipher.algo =3D RTE_CRYPTO_CIPHER_AES_CBC; > cipher_xform.cipher.op =3D RTE_CRYPTO_CIPHER_OP_ENCRYPT; >=20 > + cipher_xform.cipher.key.data =3D cipher_key; > + cipher_xform.cipher.key.length =3D 16; > + cipher_xform.cipher.iv.offset =3D IV_OFFSET; > + cipher_xform.cipher.iv.length =3D 16; > + > op =3D rte_crypto_op_alloc(params.op_mpool, > RTE_CRYPTO_OP_TYPE_SYMMETRIC); > TEST_ASSERT_NOT_NULL(op, > @@ -364,6 +370,7 @@ test_op_new_mode(uint8_t session_less) > struct rte_mbuf *m; > uint32_t cap; > int ret; > + uint8_t cipher_key[17]; >=20 > memset(&m_data, 0, sizeof(m_data)); >=20 > @@ -379,6 +386,11 @@ test_op_new_mode(uint8_t session_less) > cipher_xform.cipher.algo =3D RTE_CRYPTO_CIPHER_AES_CBC; > cipher_xform.cipher.op =3D RTE_CRYPTO_CIPHER_OP_ENCRYPT; >=20 > + cipher_xform.cipher.key.data =3D cipher_key; > + cipher_xform.cipher.key.length =3D 16; > + cipher_xform.cipher.iv.offset =3D IV_OFFSET; > + cipher_xform.cipher.iv.length =3D 16; > + > op =3D rte_crypto_op_alloc(params.op_mpool, > RTE_CRYPTO_OP_TYPE_SYMMETRIC); > TEST_ASSERT_NOT_NULL(op, "Failed to allocate crypto_op!\n"); > -- > 2.17.1