From: Olivier MATZ <olivier.matz@6wind.com>
To: Simon Kagstrom <simon.kagstrom@netinsight.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] mbuf/ip_frag: Move mbuf chaining to common code
Date: Tue, 13 Oct 2015 15:11:49 +0200 [thread overview]
Message-ID: <561D0315.7090703@6wind.com> (raw)
In-Reply-To: <20150907145009.43cb1634@miho>
Hi Simon,
On 09/07/2015 02:50 PM, Simon Kagstrom wrote:
> Chaining/segmenting mbufs can be useful in many places, so make it
> global.
>
> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> Signed-off-by: Johan Faltstrom <johan.faltstrom@netinsight.net>
>
> [...]
>
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -1775,6 +1775,40 @@ static inline int rte_pktmbuf_is_contiguous(const struct rte_mbuf *m)
> }
>
> /**
> + * Chain an mbuf to another, thereby creating a segmented packet.
> + *
> + * Note: The implementation will do a linear walk over the segments to find
> + * the tail entry. For cases when there are many segments, it's better to
> + * chain the entries manually.
> + *
> + * @param head the head of the mbuf chain (the first packet)
> + * @param tail the mbuf to put last in the chain
> + *
> + * @return 0 on success, -EOVERFLOW if the chain is full (256 entries)
> + */
Small nit about the API comment, it should be:
@param head
The head of the mbuf chain (the first packet).
...
(note the uppercase and the dot at the end, see the other functions
in the file)
I know Thomas usually fixes this kind of stuff when he pushes
the patches, but it's better if we can avoid him this load :)
Regards,
Olivier
prev parent reply other threads:[~2015-10-13 13:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 12:41 [dpdk-dev] [PATCH RFC] " Simon Kagstrom
2015-09-07 7:32 ` Olivier MATZ
2015-09-07 9:13 ` Ananyev, Konstantin
2015-09-07 9:35 ` Olivier MATZ
2015-09-07 10:40 ` Simon Kågström
2015-09-07 11:43 ` [dpdk-dev] [PATCH v2] " Simon Kagstrom
2015-09-07 12:32 ` Ananyev, Konstantin
2015-09-07 12:41 ` Simon Kågström
2015-09-07 23:21 ` Ananyev, Konstantin
2015-09-08 10:40 ` Simon Kågström
2015-09-09 8:22 ` Ananyev, Konstantin
2015-09-07 12:50 ` [dpdk-dev] [PATCH v3] " Simon Kagstrom
2015-10-13 12:50 ` Simon Kagstrom
2015-10-13 13:17 ` Thomas Monjalon
2015-10-13 13:11 ` Olivier MATZ [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561D0315.7090703@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=simon.kagstrom@netinsight.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).