From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <amine.kherbouche@6wind.com>
Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com
 [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 0B5C58D95
 for <dev@dpdk.org>; Wed, 14 Oct 2015 13:39:47 +0200 (CEST)
Received: by wicge5 with SMTP id ge5so96867118wic.0
 for <dev@dpdk.org>; Wed, 14 Oct 2015 04:39:46 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:subject:to:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-type
 :content-transfer-encoding;
 bh=LUtICXp2r6ksWUbfXdZBC4ZpsZEAGws1b0tVEJ/Ez6c=;
 b=BmVReOCZ0vmGPIKmwaf6waF7xjm2732c/sYA48IAx8sqxbUU7JhHNgOq1UbjzKrCtE
 HuQvpQ61tjWgc5GHGs33jRlceYakJOnzYGszrhiUg9aT2swszu/F7T/cuk2dYJLXfxwQ
 z1UKFgvGJtl3Xl5z3HPaqBy9Gi9wZNRhDHdWVqIc7IKKlMZHWByicHaPg521IeXkPDmI
 ZP0VNg6Yy++97l9AqlBopO7I/MBdTmcweshSJKvj5mXs21SvGCZN0sA4nqauIBBredMX
 lela9lnttlau5poGRCq02zBcCFKogZsCcSBYury+VbtLjluS2+jNUEr6m6AMWpp4wP8L
 44VQ==
X-Gm-Message-State: ALoCoQkfq7H+w06aZd2Hn369n21dleuflpKylpIHcQhW+AHGUSDTM0ZYUaaQ72cRgSgk8rNwnkFu
X-Received: by 10.194.184.20 with SMTP id eq20mr3566817wjc.22.1444822786803;
 Wed, 14 Oct 2015 04:39:46 -0700 (PDT)
Received: from [10.16.0.135] (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by smtp.gmail.com with ESMTPSA id gh9sm9502023wjb.27.2015.10.14.04.39.45
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 14 Oct 2015 04:39:46 -0700 (PDT)
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, dev@dpdk.org
References: <1443729293-20753-2-git-send-email-konstantin.ananyev@intel.com>
From: Amine Kherbouche <amine.kherbouche@6wind.com>
Message-ID: <561E3EF2.1040507@6wind.com>
Date: Wed, 14 Oct 2015 13:39:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <1443729293-20753-2-git-send-email-konstantin.ananyev@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [dpdk-dev, PATCHv5,
 1/8] ethdev: add new API to retrieve RX/TX queue information
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Oct 2015 11:39:47 -0000



Hi Konstantin
> +/**
> + * Ethernet device RX queue information structure.
> + * Used to retieve information about configured queue.
> + */
> +struct rte_eth_rxq_info {
> +	struct rte_mempool *mp;     /**< mempool used by that queue. */
> +	struct rte_eth_rxconf conf; /**< queue config parameters. */
> +	uint8_t scattered_rx;       /**< scattered packets RX supported. */
> +	uint16_t nb_desc;           /**< configured number of RXDs. */
Here i need two more fields in this struct :
     uint16_t free_desc : for free queue descriptors
     uint16_t used_desc : for used queue descriptors
> +} __rte_cache_aligned;
> +
> +/**
> + * Ethernet device TX queue information structure.
> + * Used to retieve information about configured queue.
> + */
> +struct rte_eth_txq_info {
> +	struct rte_eth_txconf conf; /**< queue config parameters. */
> +	uint16_t nb_desc;           /**< configured number of TXDs. */
And also here.
> +} __rte_cache_aligned;
> +
>   struct rte_eth_dev;
How to add them without breaking API ? I would prefer to see them now, so
I'll send an update on your patch series that i'll use this 2 more
fields. The purpose will be to provide analysis of the usage of the RX
and TX queues.