Re: [dpdk-dev] [PATCH v5 4/9] null: virtual dynamic rss configuration

[Tetsuya Mukawa <mukawa@igel.co.jp>]

On 2015/10/15 17:42, Kulasek, TomaszX wrote:
>> -----Original Message-----
>> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp]
>> Sent: Thursday, October 15, 2015 09:46
>> To: Kulasek, TomaszX; dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v5 4/9] null: virtual dynamic rss
>> configuration
>>
>> On 2015/09/30 23:05, Tomasz Kulasek wrote:
>>> This implementation allows to set and read RSS configuration for null
>>> device, and is used to validate right values propagation over the
>>> slaves, in test units for dynamic RSS configuration for bonding.
>>>
>>> v5 changes:
>>>  - replaced memcpy with rte_memcpy
>>>
>>> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
>>> ---
>>>  drivers/net/null/rte_eth_null.c |  116
>>> +++++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 116 insertions(+)
>>>
>>> diff --git a/drivers/net/null/rte_eth_null.c
>>> b/drivers/net/null/rte_eth_null.c index bf81b1b..b01f647 100644
>>> --- a/drivers/net/null/rte_eth_null.c
>>> +++ b/drivers/net/null/rte_eth_null.c
>>> @@ -37,6 +37,8 @@
>>>  #include <rte_memcpy.h>
>>>  #include <rte_dev.h>
>>>  #include <rte_kvargs.h>
>>> +#include <rte_eth_null.h>
>>> +#include <rte_spinlock.h>
>>>
>>>
>>
>> Hi Tomasz,
>>
>> We don't have "rte_eth_null.h" at this point.
>> (The header file will be added next patch) Probably, we also need
>> "rte_pmd_null_version.map" to compile correctly.
>> (To make sure, please compile DPDK with "CONFIG_RTE_BUILD_SHARED_LIB=y"
>> option.)
>>
>> Also, it seems 'rte_eth_null.h' should be included like below.
>> #include "rte_eth_null.h"
>> Without it, we cannot compile.
>>
>> Thanks,
>> Tetsuya
> Hi Tetsuya,
>
> This file and modifications are already included in "[dpdk-dev,v5,5/9] null: export eth_dev_null_create" in the patch set, also the required symlink is created like below:

Hi Tomasz,

But "rte_eth_null.h" is used in " [PATCH v5 4/9] null: virtual dynamic
rss configuration".
It means we cannot compile DPDK before applying "[dpdk-dev,v5,5/9]".
When we need to use git-bisect, this will be problem.
So could you please keep DPDK being able to compile at any point?

Thanks,
Tetsuya,