From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) by dpdk.org (Postfix) with ESMTP id 2284C8E8F for ; Thu, 15 Oct 2015 11:21:59 +0200 (CEST) Received: by payp3 with SMTP id p3so34698327pay.1 for ; Thu, 15 Oct 2015 02:21:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=35aVVkB88uG81uuVt/4nlfy5EZX8tRFJT8+SC1kY5Bk=; b=BtaGOpWmMNwsJ6XujXK0ZnwbYNeXauAlnuELABIaRYh2p4Cj5ClZBHhJeMynuiMfzv ayWRauTISnfPElHUJV1ZCwZGpAdo1cvwo8z+1YFDqyRyKSa2X3BonMZjX0pxxBnSzDem sWx2URlmd7LAPv0ldBgQLW4JT2dM99WMrl8gYsT5R3ev7s/MEjMzqKtVNIDpaibMHNqS x+AzznqAYW5/cFnFpeNGVhv92+BYOU1oRILdG5CLLFZ2lVLIvTcOO1/5JZM01f4QwVDq I3/1fRJPqeui9Gp/lj5hcjSgJHD9F5ZINeu27CAZi1BAk5Z+ZUIhXNYTkVpqSi+SyAgj k47Q== X-Gm-Message-State: ALoCoQnjUOyeFMvNNRdU5npWU7BK4zC75W+5vhXE3RX9mTB+0lZdjJMagKIbAYBdEYViG9OPjh1I X-Received: by 10.66.229.67 with SMTP id so3mr9145652pac.66.1444900918418; Thu, 15 Oct 2015 02:21:58 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id ce3sm14191239pbb.35.2015.10.15.02.21.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Oct 2015 02:21:57 -0700 (PDT) To: "Kulasek, TomaszX" , "dev@dpdk.org" References: <1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com> <1443621905-7872-1-git-send-email-tomaszx.kulasek@intel.com> <1443621905-7872-5-git-send-email-tomaszx.kulasek@intel.com> <561F59C8.1070105@igel.co.jp> <3042915272161B4EB253DA4D77EB373A14E09865@IRSMSX102.ger.corp.intel.com> From: Tetsuya Mukawa X-Enigmail-Draft-Status: N1110 Message-ID: <561F7034.1060909@igel.co.jp> Date: Thu, 15 Oct 2015 18:21:56 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <3042915272161B4EB253DA4D77EB373A14E09865@IRSMSX102.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 4/9] null: virtual dynamic rss configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2015 09:21:59 -0000 On 2015/10/15 17:42, Kulasek, TomaszX wrote: >> -----Original Message----- >> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] >> Sent: Thursday, October 15, 2015 09:46 >> To: Kulasek, TomaszX; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v5 4/9] null: virtual dynamic rss >> configuration >> >> On 2015/09/30 23:05, Tomasz Kulasek wrote: >>> This implementation allows to set and read RSS configuration for null >>> device, and is used to validate right values propagation over the >>> slaves, in test units for dynamic RSS configuration for bonding. >>> >>> v5 changes: >>> - replaced memcpy with rte_memcpy >>> >>> Signed-off-by: Tomasz Kulasek >>> --- >>> drivers/net/null/rte_eth_null.c | 116 >>> +++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 116 insertions(+) >>> >>> diff --git a/drivers/net/null/rte_eth_null.c >>> b/drivers/net/null/rte_eth_null.c index bf81b1b..b01f647 100644 >>> --- a/drivers/net/null/rte_eth_null.c >>> +++ b/drivers/net/null/rte_eth_null.c >>> @@ -37,6 +37,8 @@ >>> #include >>> #include >>> #include >>> +#include >>> +#include >>> >>> >> >> Hi Tomasz, >> >> We don't have "rte_eth_null.h" at this point. >> (The header file will be added next patch) Probably, we also need >> "rte_pmd_null_version.map" to compile correctly. >> (To make sure, please compile DPDK with "CONFIG_RTE_BUILD_SHARED_LIB=y" >> option.) >> >> Also, it seems 'rte_eth_null.h' should be included like below. >> #include "rte_eth_null.h" >> Without it, we cannot compile. >> >> Thanks, >> Tetsuya > Hi Tetsuya, > > This file and modifications are already included in "[dpdk-dev,v5,5/9] null: export eth_dev_null_create" in the patch set, also the required symlink is created like below: Hi Tomasz, But "rte_eth_null.h" is used in " [PATCH v5 4/9] null: virtual dynamic rss configuration". It means we cannot compile DPDK before applying "[dpdk-dev,v5,5/9]". When we need to use git-bisect, this will be problem. So could you please keep DPDK being able to compile at any point? Thanks, Tetsuya,