From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A20F28D9B for ; Thu, 15 Oct 2015 14:32:39 +0200 (CEST) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 7A9DFA0BA7; Thu, 15 Oct 2015 12:32:38 +0000 (UTC) Received: from dhcp195.koti.laiskiainen.org (vpn1-4-76.ams2.redhat.com [10.36.4.76]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9FCWaxl019240; Thu, 15 Oct 2015 08:32:37 -0400 To: "Arevalo, Mario Alfredo C" , "dev@dpdk.org" References: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1444076406-30141-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <6594B51DBE477C48AAE23675314E6C460F1B459A@fmsmsx107.amr.corp.intel.com> From: Panu Matilainen Message-ID: <561F9CE4.7010406@redhat.com> Date: Thu, 15 Oct 2015 15:32:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <6594B51DBE477C48AAE23675314E6C460F1B459A@fmsmsx107.amr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Subject: Re: [dpdk-dev] [PATCH v4 0/7] Add instalation rules for dpdk files. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2015 12:32:40 -0000 On 10/10/2015 08:45 PM, Arevalo, Mario Alfredo C wrote: > Hi, > > Good day, I was wondering if someone has any comment about it :) Hi, sorry been busy with some other agendas :) See below... > > v4: > > Modify the makefile target to specify the files > that will be installed using a rule: > > * make install-bin (install app files)(dafault path BIN_DIR=/usr/bin). > > * make install-headers (install headers)(dafault path INCLUDE_DIR=/usr/include/dpdk). > > * make install-lib (install libraries)(dafault path if the architecture is 64 bits > is LIB_DIR=/usr/lib64 else LIB_DIR=/usr/lib). I still maintain the LIB_DIR heuristic around x86_64 arch is broken and that we'll be better off without it. Even auto*tools and cmake dont try to guess this. If you insist on heuristics, you'll need help from other tools, eg on systems where systemd-path is available, you can get a reasonable well-educated guess from it with "systemd-path system-library-arch". > > * make install-doc (install documentation)(dafault path DOC_DIR=/usr/share/doc/dpdk). > > * make install-mod (install modules)(dafault path if RTE_EXEC_ENV=linuxapp then > KERNEL_DIR=/lib/modules/$(uname -r)/extra/drivers/dpdk else KERNEL_DIR=/boot/modules). Just noticed, this creates the /lib/modules structure even if there are no kernel modules to install. Not the end of the world of course. > * make install-sdk (install headers, makefiles, scripts,examples, tools and > config files) (default path DATA_DIR=/usr/share/dpdk). > > * make install-fhs (install libraries, modules, app files, > nic bind files and documentation). I still think that install-fhs should include headers as well, that is what all normal OSS software does on "make install" anyway. Or just install it all (ie whole -sdk). The documentation installed with install-fhs includes things like the programmers guide, which is of little use without the sdk bits. - Pan u-