Re: [dpdk-dev] [PATCH v4 0/7] Add instalation rules for dpdk files.

[Olivier MATZ <olivier.matz@6wind.com>]

Hi Mario,

Few last comments here, please see below.

On 10/05/2015 10:19 PM, Mario Carrillo wrote:
> DPDK package lacks of a mechanism to install libraries, headers
> applications, kernel modules and sdk files to a file system tree.
> 
> This patch set allows to install files according to the next
> proposal:
> http://www.freedesktop.org/software/systemd/man/file-hierarchy.html
> however this patch set does not affect the current dpdk behavior.
> 
> Using rules support is possible to do the next steps:
> make config T=TARGET
> make
> make INSTALL-TARGET

Just for sake of clarity: the 2 words TARGET are for different things,
right? Maybe it could be replaced by:

  make config T=<config template>
  make
  make <install target>



Thinking a bit more about "make install" current behavior and
the new one.

Today, I think nobody uses "make install" without T=. Indeed,
it is not possible to build all targets (bsd + linux) on the
same host.

So, it won't break anything to have:

  make install    -> do the same than your "make install-fhs"
  make install T=<templates>    -> same than before

In the future, to avoid confusion, we could deprecate the
"make install T=" or rename it in something else... even remove
it if there is an alternative with the new file hierarchy that
you are introducing.


Last comment, I think the "make help" and some documentation
files should be updated to reflect your changes.


Thank you for working on this!

Regards,
Olivier