From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 172B78DA7
 for <dev@dpdk.org>; Fri, 16 Oct 2015 21:32:39 +0200 (CEST)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10])
 by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84) (envelope-from <olivier.matz@6wind.com>)
 id 1ZnAkS-0002ag-3Y; Fri, 16 Oct 2015 21:33:04 +0200
Message-ID: <562150D0.3030006@6wind.com>
Date: Fri, 16 Oct 2015 21:32:32 +0200
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.7.0
MIME-Version: 1.0
To: Mario Carrillo <mario.alfredo.c.arevalo@intel.com>, dev@dpdk.org
References: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com>
 <1444076406-30141-1-git-send-email-mario.alfredo.c.arevalo@intel.com>
In-Reply-To: <1444076406-30141-1-git-send-email-mario.alfredo.c.arevalo@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 0/7] Add instalation rules for dpdk files.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Oct 2015 19:32:39 -0000

Hi Mario,

Few last comments here, please see below.

On 10/05/2015 10:19 PM, Mario Carrillo wrote:
> DPDK package lacks of a mechanism to install libraries, headers
> applications, kernel modules and sdk files to a file system tree.
> 
> This patch set allows to install files according to the next
> proposal:
> http://www.freedesktop.org/software/systemd/man/file-hierarchy.html
> however this patch set does not affect the current dpdk behavior.
> 
> Using rules support is possible to do the next steps:
> make config T=TARGET
> make
> make INSTALL-TARGET

Just for sake of clarity: the 2 words TARGET are for different things,
right? Maybe it could be replaced by:

  make config T=<config template>
  make
  make <install target>



Thinking a bit more about "make install" current behavior and
the new one.

Today, I think nobody uses "make install" without T=. Indeed,
it is not possible to build all targets (bsd + linux) on the
same host.

So, it won't break anything to have:

  make install    -> do the same than your "make install-fhs"
  make install T=<templates>    -> same than before

In the future, to avoid confusion, we could deprecate the
"make install T=" or rename it in something else... even remove
it if there is an alternative with the new file hierarchy that
you are introducing.


Last comment, I think the "make help" and some documentation
files should be updated to reflect your changes.


Thank you for working on this!

Regards,
Olivier