From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 66B7B1041 for ; Mon, 15 Jan 2018 00:25:23 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0748220800; Sun, 14 Jan 2018 18:25:23 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sun, 14 Jan 2018 18:25:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=pbCQuZqOUj09tcb+bTn9tDGnIz dOzoQOAsVRo49DbtM=; b=TF7zwaWHQUg5QmrMsx78HaMhYcHAlb4YVqjR5+S6Yy 9S3XCVTBoGcPpoH21YWJ7NIW9Q70nkqPNwQCg8ksoR/qlTo6iF9IZikTok3752lu gw49ul5WjHdXukbnLJCPiTqGfbm8TXN405qlXMl2BTIo9vz2ZdQLloxkdloMd4Rz o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=pbCQuZ qOUj09tcb+bTn9tDGnIzdOzoQOAsVRo49DbtM=; b=fk8DoBaxe0H+NwOSXNFwmH Ao2mzF5BqBymRV2HZ0YtHu9XakpCWrXHzGJ9dK+NnLcMAPAzj+WSo2dFmspN0oD2 T27QUIKEV7qsOdp03XOlno6KI+f+f6zdr/BXzx9Awwvl9n9YCl4HtZCcMs3x0Bfj liMBzEKnCKi1dXm753YoP1+2iV+VpKFiri4Fb+GDrSbbugzwkFAnMVTHm9LW1yJi fIb0Be1JM/7fbo8oBWUFXy1y+RKvI2c3sPsS3TffStrWnQmAXnznkLNQBP8/apsg /vYsEwFTTfDK9zEU86dEbtLQZvEUTJQEgQVhuybnimtYZg1lFOrZ4JQGMkJvtfHQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A424A246D8; Sun, 14 Jan 2018 18:25:22 -0500 (EST) From: Thomas Monjalon To: Jeff Guo Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, gaetan.rivet@6wind.com, konstantin.ananyev@intel.com, jblunck@infradead.org, shreyansh.jain@nxp.com, jingjing.wu@intel.com, helin.zhang@intel.com, motih@mellanox.com Date: Mon, 15 Jan 2018 00:24:51 +0100 Message-ID: <5621685.YHClJoWfgs@xps> In-Reply-To: <1515679534-22473-2-git-send-email-jia.guo@intel.com> References: <1515575544-2141-3-git-send-email-jia.guo@intel.com> <1515679534-22473-1-git-send-email-jia.guo@intel.com> <1515679534-22473-2-git-send-email-jia.guo@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH V10 2/2] eal: add uevent pass and process function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jan 2018 23:25:23 -0000 11/01/2018 15:05, Jeff Guo: > +enum rte_dev_state { > + RTE_DEV_UNDEFINED, /**< unknown device state */ > + RTE_DEV_FAULT, /**< device fault or error */ > + RTE_DEV_PARSED, /**< device have been parsed on bus*/ > + RTE_DEV_PROBED, /**< devcie have been probed driver */ > +}; Let's start with nitpicks: please be careful with spacing in comments. + typo: devcie + grammar: device has What means parsed on bus? Is it "scanned"? > +enum rte_dev_subsystem { > + RTE_DEV_SUBSYSTEM_UIO, > + RTE_DEV_SUBSYSTEM_VFIO, > + RTE_DEV_SUBSYSTEM_PCI, > + RTE_DEV_SUBSYSTEM_MAX > +}; I don't think PCI and UIO/VFIO should be described at the same level. Can you re-use the enum rte_kernel_driver? > +enum event_monitor_netlink_group { > + RTE_DEV_EVENT_MONITOR_KERNEL, > + RTE_DEV_EVENT_MONITOR_UDEV, > +}; This enum should be prefixed with rte_ > + enum event_monitor_netlink_group group; /**< device netlink group */ netlink is specific to Linux. I don't think it should be in a generic API struct.