Re: [dpdk-dev] [PATCH v5 0/4] bonding corrections and additions

[Declan Doherty <declan.doherty@intel.com>]

On 30/09/15 18:48, Eric Kinzie wrote:
> This patchset makes a couple of small corrections to the bonding driver
> and introduces the ability to use an external state machine for mode
> 4 operation.
>
> Changes in v2:
>    . eliminate external_sm field in 802.3ad configuration
>      (rte_eth_bond_8023ad_conf).
>    . stop bonding device before changing the periodic callback function.
>      start again if needed.
>    . remove unnecessary calls to valid_bonded_port_id().
>    . do not check for NULL tx_ring.
>    . return error in rte_eth_bond_8023ad_ext_slowtx() if packet is not LACP.
>    . remove check for external sm configuration in periodic callback
>    . check for valid LACPDU in test application's rx callback
>    . add "Fixes:" tags
>
> Changes in v3:
>    . update rte_eth_bond_version.map
>
> Changes in v4:
>    . version functions that modify slowrx_cb
>
> Changes in v5:
>    . remove "__vsym" from source files and use updated symbol version macros
>
> Eric Kinzie (4):
>    bond mode 4: copy entire config structure
>    bond mode 4: do not ignore multicast
>    bond mode 4: allow external state machine
>    bond mode 4: tests for external state machine
>
>   app/test/test_link_bonding_mode4.c                |  217 ++++++++++++++++++-
>   drivers/net/bonding/Makefile                      |    2 +-
>   drivers/net/bonding/rte_eth_bond_8023ad.c         |  241 ++++++++++++++++++++-
>   drivers/net/bonding/rte_eth_bond_8023ad.h         |   44 ++++
>   drivers/net/bonding/rte_eth_bond_8023ad_private.h |   28 +++
>   drivers/net/bonding/rte_eth_bond_pmd.c            |    1 +
>   drivers/net/bonding/rte_eth_bond_version.map      |    3 +
>   7 files changed, 522 insertions(+), 14 deletions(-)
>

Hey Eric, the patch set looks good, the only issue is that the 
versioning referrers to 2.1 now instead of 2.2, if you could fix that, 
I'll ack straight away.

Thanks
Declan