From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F30EAA034F; Thu, 25 Feb 2021 13:01:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7213A406B4; Thu, 25 Feb 2021 13:01:16 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 0AAE840692 for ; Thu, 25 Feb 2021 13:01:15 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 7640C5C00AF; Thu, 25 Feb 2021 07:01:14 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 25 Feb 2021 07:01:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= btkvT4k9oTZWGz9/xR29gTl/l57JcykyK5Mwj6+qvdg=; b=m+ZkZNEAiof46qqo 4+q+iG+hbXTrDPzBNwK1BKNBCwhnHcVnEeXtRNUFKwKc1g+ns+NXGhrXWMxn0Lcb 7KhaHuRn4IgOVrXnP2NTqg5hvR63XnIQO2bmZA8tr0jAwlZW3mvTn5ggUFzlhENh 7ryFtG1u//073HNGrJxwjiCxhKo+bSHQQ3zLeKp3uzJoqBceDYwaOkQpeiCI07zV EQbNER5Tqzd13BrvRuHpSy5a/k7InmgHl+jeumigAqvr586vYnXTI+jxnbvOzHP+ Z0i8bL8eHRI1uKf2cPFwIe4PKJLGnPHjo0YsoxmY/tsog3PzMOSaRGZQLXy/FYAN KfBBEw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=btkvT4k9oTZWGz9/xR29gTl/l57JcykyK5Mwj6+qv dg=; b=OXJq9Dpd07eYh2tGHLK62hz8ibkjsnIfvc+Ktv+O0CNRCAPG7x71CVjWV cwZXGYzSEHFMelPqsllxeVlsDns9YJWYb46WcWi4y8GgI2j6Oz7ewWMwJC3E4EOo HELZlpBFNdU3QN2UnwISWBxodBA7xw327IwDcZdegxAb/5KiNaaiWjeBnHxllXRj Xm4fq9cu+M3uMT9P6QWyvP50fbf4EEOelwZiscuXh1IocanvMy5j6M80LgbQpBGj cAdKyucfRJxP2bR5ztZchVdfLnxZv9h4FzTh8rQAPWhmaw+xXon+Jebfxry3HRnO c+BFNLDPI9Aq3ys9ivV5I8L6Cj7TQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrkeelgdefiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DB33224005B; Thu, 25 Feb 2021 07:01:12 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: David Marchand , dev@dpdk.org, ferruh.yigit@intel.com Date: Thu, 25 Feb 2021 13:01:10 +0100 Message-ID: <5625752.shjfW9zSB4@thomas> In-Reply-To: <20210225115720.GA1546@bricha3-MOBL.ger.corp.intel.com> References: <20210225111457.32540-1-david.marchand@redhat.com> <2047120.oh6f1MFQjV@thomas> <20210225115720.GA1546@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/02/2021 12:57, Bruce Richardson: > On Thu, Feb 25, 2021 at 12:41:16PM +0100, Thomas Monjalon wrote: > > 25/02/2021 12:14, David Marchand: > > > Add a check on versioned symbol duplicates in map files. > > > > > > Signed-off-by: David Marchand > > > --- > > > This check could be added to buildtools/check-symbols.sh so that > > > regular developers catch the issue when building their changes... > > > Opinions? > > > > In general I am against adding developer tools in the build process, > > because it could cause more issues for normal users. > > > Is this really likely to cause issues for normal users? Yes because some users will have a different shell, or other weird setup we don't think about yet. > If we add this to > the build process any issues will surely be caught be developers before > merge. If we want the checks to be more popular, we should write a script to help running the right script at the right time, and ideally help in the contribution process.