From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 295C1374E for ; Tue, 27 Oct 2015 13:01:34 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 27 Oct 2015 05:01:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,204,1444719600"; d="scan'208";a="804240486" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.220.76]) ([10.237.220.76]) by orsmga001.jf.intel.com with ESMTP; 27 Oct 2015 05:01:09 -0700 From: Sergio Gonzalez Monroy To: "shesha Sreenivasamurthy (shesha)" , "dev@dpdk.org" References: <1445419101-19690-1-git-send-email-shesha@cisco.com> <562F633B.2090806@intel.com> Message-ID: <562F6784.80704@intel.com> Date: Tue, 27 Oct 2015 12:01:08 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <562F633B.2090806@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] mem: command line option to delete hugepage backing files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2015 12:01:34 -0000 On 27/10/2015 11:42, Sergio Gonzalez Monroy wrote: > On 21/10/2015 17:22, shesha Sreenivasamurthy (shesha) wrote: >> When an application using huge-pages crash or exists, the hugetlbfs >> backing files are not cleaned up. This is a patch to clean those files. >> There are multi-process DPDK applications that may be benefited by those >> backing files. Therefore, I have made that configurable so that the >> application that does not need those backing files can remove them, thus >> not changing the current default behavior. The application itself can >> clean it up, however the rationale behind DPDK cleaning it up is, DPDK >> created it and therefore, it is better it unlinks it. >> >> Signed-off-by: Shesha Sreenivasamurthy >> --- >> lib/librte_eal/common/eal_common_options.c | 12 ++++++++++++ >> lib/librte_eal/common/eal_internal_cfg.h | 1 + >> lib/librte_eal/common/eal_options.h | 2 ++ >> lib/librte_eal/linuxapp/eal/eal_memory.c | 30 >> ++++++++++++++++++++++++++++++ >> 4 files changed, 45 insertions(+) >> > You need to update patchwork to reflect that v4 is rejected and set v3 > with 'New' state. > > Acked-by: Sergio Gonzalez Monroy Hi Shesha, Even though the test-report says the patch is good, it is not. For some reason it is wrapping some lines (76, 93, 106, 129) causing the errors. You can add my Acked-by when you resend the patch. Sergio