From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by dpdk.org (Postfix) with ESMTP id 1A144378E for ; Thu, 29 Oct 2015 08:19:24 +0100 (CET) Received: by padhy1 with SMTP id hy1so26393728pad.0 for ; Thu, 29 Oct 2015 00:19:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel_co_jp.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=upEyhDA5ZEF4RICyzVNkiB7z3GZqY5TDTi6Tw8+r2tg=; b=1weAXJNyI6aKfStn7UmC5/MQM+a+7myrl2DXLJdhLHckhmrjWD/M0k2xPMO0Lptmu/ N7kzl1M3GMlUKw0xCecHWOFctnnla66v5hSTNEmAaumS5Xlm40RyTWAFYnqJrZ/+fJrJ pcBNi5RMXqr90GG8Rinajpra/5nYiEKL5r1Kn48I+GKYClXBXf7tT2sx2iqLwdmUDS0B +29EmgxhVQXPTM+E6Z3vX/sCxc3izr4OoOcMNMS0vydYqJce3uyY9RtFzrdma2W0DHgG yBZLWHXl1ucRaJj4w7ilj7Zbg3XSRlahtzWDpXauJa/JuqCSVE0n6vOXrDx9F6oI4s3p bJQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=upEyhDA5ZEF4RICyzVNkiB7z3GZqY5TDTi6Tw8+r2tg=; b=AIhFEPiGs1oMfs1CJ08sjIde5hnX6ihS0RyQfx6Dv6y/bi15ntcq0qYmzhW60bdp+w S2IMo9l9kpU8WgUlVzBVhMPpeerEDgG2sRUD5QJ9ach1XnZMKRC8hcwyMD7cB3EXSbyM HOID5bu5MTSEuo8k3jdTZQOS+kQf5uBdYIokGb+JfcLT9zzXIx3zV6ZsRMdqGSnXjPCc sf8UUvseY/DL78MWoJs5jIJbzBonLdLlHzf3xO6ana+HrOHobGgUk2VouNSX8ua1N9vV lGUPyfE03k1FICd3Ezv8LS6qmPGYtLnXdow3wHkj8Sg61abHfH0+thYx4gE/diggTOtm /xKQ== X-Gm-Message-State: ALoCoQnV4ZIzoN6uIm6uCjD7wpkXOstrEc0QeeWvwwdSwkwIyBbljnvKH3RfJ0/StMPGVe/Fg29G X-Received: by 10.68.57.129 with SMTP id i1mr261998pbq.51.1446103163315; Thu, 29 Oct 2015 00:19:23 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id ci2sm380564pbc.66.2015.10.29.00.19.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Oct 2015 00:19:22 -0700 (PDT) To: "Kulasek, TomaszX" References: <1443621905-7872-1-git-send-email-tomaszx.kulasek@intel.com> <1444989651-6236-1-git-send-email-tomaszx.kulasek@intel.com> <1444989651-6236-3-git-send-email-tomaszx.kulasek@intel.com> <7064813.L2uCrhhELF@xps13> <3042915272161B4EB253DA4D77EB373A14E0C5E1@IRSMSX102.ger.corp.intel.com> From: Tetsuya Mukawa X-Enigmail-Draft-Status: N1110 Message-ID: <5631C878.8060003@igel.co.jp> Date: Thu, 29 Oct 2015 16:19:20 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <3042915272161B4EB253DA4D77EB373A14E0C5E1@IRSMSX102.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v6 2/9] null: fix segfault when null_pmd added to bonding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2015 07:19:24 -0000 On 2015/10/28 22:43, Kulasek, TomaszX wrote: >> -----Original Message----- >> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] >> Sent: Tuesday, October 27, 2015 17:59 >> To: Kulasek, TomaszX >> Cc: dev@dpdk.org; Tetsuya Mukawa >> Subject: Re: [dpdk-dev] [PATCH v6 2/9] null: fix segfault when null_pmd >> added to bonding >> >> Hi, >> There is no change in v6 for this patch which was acked by Tetsuya. >> So why not keep the Acked-by below your Signed-off-by? >> >> It seems patches 2, 3, 4 and 5 were Acked by Tetsuya. >> Other acks I'm missing? >> > Hi, > > Patches 4 and 5 were changed due to the Tetsuya's suggestions and already reviewed. There are not big changes, but I'm not sure if it should be reacked by Tetsuya, or I can just copy ack? > > Tomasz Hi Tomasz, Could you please check Bernard's patch series? - [PATCH v5 00/28] remove pci driver from vdevs He tries to remove pci_drv from PMD. It seems your below patch will be affected by his patch. - null: fix segfault when null_pmd added to bonding I just wonder your bonding RSS patch works without below fixing. drivers/net/null/rte_eth_null.c : + pci_dev->driver = &rte_null_pmd.pci_drv; Anyway, Could you please check him patches? Thanks, Tetsuya