From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 786A0922C for ; Fri, 30 Oct 2015 17:28:28 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 30 Oct 2015 09:28:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,219,1444719600"; d="scan'208";a="838971637" Received: from dhunt5x-mobl3.ger.corp.intel.com (HELO [10.237.208.62]) ([10.237.208.62]) by orsmga002.jf.intel.com with ESMTP; 30 Oct 2015 09:28:26 -0700 To: Jan Viktorin References: <1446212826-19425-7-git-send-email-david.hunt@intel.com> <5633798B.2050708@intel.com> <20151030161106.4657232.16920.465@rehivetech.com> From: "Hunt, David" Message-ID: <56339AA9.1060505@intel.com> Date: Fri, 30 Oct 2015 16:28:25 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151030161106.4657232.16920.465@rehivetech.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 6/6] test: add checks for cpu flags on armv8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2015 16:28:28 -0000 On 30/10/2015 16:11, Jan Viktorin wrote: > Hmm, I see. It's good to fix this in the generated e-mails between format-patch > and send-email calls. I always review those to be sure they meet my expectations ;). > Anyway, it is not clear, what has changed in the v3. Just the rte_cycles? > You should explain that at least in the 0000 patch. Better to keep some history > in each single commit (are there any rules in dpdk for this? Just look how they do in kernel). --snip-- Sure, I'll keep that in mind for the next time. A list of changes for each revision, and also changes in each patch in the patch set. As Thomas says - whatever helps the reviewer :) For the moment there probably isn't a need to release a new patch set for these comments, so I'll just list them here: 1. v3 has just the additional comment in one of the patches to say that the armv8 header files are in the 'arm' include directory. 2. The rte_cycles is unchanged, the CONFIG_ is not needed. If there is a need to post another patch set I'll include the change notes. Otherwise do we all think that the patch is there (or there abouts)? :) Regards, Dave.