From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cunming.liang@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id D49F95A64
 for <dev@dpdk.org>; Wed,  4 Nov 2015 02:38:08 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga103.jf.intel.com with ESMTP; 03 Nov 2015 17:38:08 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,240,1444719600"; d="scan'208";a="826313228"
Received: from shwdeisgchi017.ccr.corp.intel.com (HELO [10.239.66.70])
 ([10.239.66.70])
 by fmsmga001.fm.intel.com with ESMTP; 03 Nov 2015 17:37:38 -0800
To: David Marchand <david.marchand@6wind.com>
References: <1443072831-19065-1-git-send-email-cunming.liang@intel.com>
 <1446182873-28814-1-git-send-email-cunming.liang@intel.com>
 <1446182873-28814-8-git-send-email-cunming.liang@intel.com>
 <CALwxeUvbpw6tp1Nu_aUeCLaOeTLEpT=44FpvZiKYS5cZuyT_fA@mail.gmail.com>
From: "Liang, Cunming" <cunming.liang@intel.com>
Message-ID: <5639615E.1010304@intel.com>
Date: Wed, 4 Nov 2015 09:37:34 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <CALwxeUvbpw6tp1Nu_aUeCLaOeTLEpT=44FpvZiKYS5cZuyT_fA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 07/11] ixgbevf: cleanup unnecessary
 interrupt handler
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Nov 2015 01:38:09 -0000

Hi David,

On 11/3/2015 12:06 AM, David Marchand wrote:
> On Fri, Oct 30, 2015 at 6:27 AM, Cunming Liang <cunming.liang@intel.com>
> wrote:
>
>> As ixgbe vf doesn't support lsc, the patch removes those unused code.
>> In addition, it does some tiny cleanup.
>>
> Please, can you describe this tiny cleanup ?
> Did it trigger some bug ?
It causes confusing to enable/allocate efd with a zero number of vector.
But this piece of code shall be merged in a different patch. Thanks.
>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
>> b/drivers/net/ixgbe/ixgbe_ethdev.c
>> index 366923f..794171c 100644
>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>> [snip]
>> @@ -3492,11 +3442,11 @@ ixgbevf_dev_start(struct rte_eth_dev *dev)
>>          ixgbevf_dev_rxtx_start(dev);
>>
>>          /* check and configure queue intr-vector mapping */
>> -       if (dev->data->dev_conf.intr_conf.rxq != 0)
>> +       if (dev->data->dev_conf.intr_conf.rxq != 0) {
>>                  intr_vector = dev->data->nb_rx_queues;
>> -
>> -       if (rte_intr_efd_enable(intr_handle, intr_vector))
>> -               return -1;
>> +               if (rte_intr_efd_enable(intr_handle, intr_vector))
>> +                       return -1;
>> +       }
>>
>>
>