DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Simon Kågström" <simon.kagstrom@netinsight.net>
To: cristian.dumitrescu@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] rte_sched: release enqueued mbufs on rte_sched_port_free()
Date: Wed, 4 Nov 2015 08:49:45 +0100	[thread overview]
Message-ID: <5639B899.7080006@netinsight.net> (raw)
In-Reply-To: <20151028105633.6a507c98@miho>

Ping?

(CC:ing Stephen Hemminger as well)

// Simon

On 2015-10-28 10:56, Simon Kagstrom wrote:
> Otherwise mbufs will leak when the port is destroyed. The
> rte_sched_port_qbase() and rte_sched_port_qsize() functions are used
> in free now, so move them up.
> 
> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> ---
>  lib/librte_sched/rte_sched.c | 44 +++++++++++++++++++++++++++-----------------
>  1 file changed, 27 insertions(+), 17 deletions(-)
> 
> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
> index 9c9419d..81462cd 100644
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> @@ -312,6 +312,23 @@ rte_sched_port_queues_per_port(struct rte_sched_port *port)
>  	return RTE_SCHED_QUEUES_PER_PIPE * port->n_pipes_per_subport * port->n_subports_per_port;
>  }
>  
> +static inline struct rte_mbuf **
> +rte_sched_port_qbase(struct rte_sched_port *port, uint32_t qindex)
> +{
> +	uint32_t pindex = qindex >> 4;
> +	uint32_t qpos = qindex & 0xF;
> +
> +	return (port->queue_array + pindex * port->qsize_sum + port->qsize_add[qpos]);
> +}
> +
> +static inline uint16_t
> +rte_sched_port_qsize(struct rte_sched_port *port, uint32_t qindex)
> +{
> +	uint32_t tc = (qindex >> 2) & 0x3;
> +
> +	return port->qsize[tc];
> +}
> +
>  static int
>  rte_sched_port_check_params(struct rte_sched_port_params *params)
>  {
> @@ -717,11 +734,21 @@ rte_sched_port_config(struct rte_sched_port_params *params)
>  void
>  rte_sched_port_free(struct rte_sched_port *port)
>  {
> +	unsigned int queue;
>  	/* Check user parameters */
>  	if (port == NULL){
>  		return;
>  	}
>  
> +	/* Free enqueued mbufs */
> +	for (queue = 0; queue < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; queue++) {
> +		unsigned int i;
> +		struct rte_mbuf **mbufs = rte_sched_port_qbase(port, queue);
> +
> +		for (i = 0; i < rte_sched_port_qsize(port, queue); i++)
> +			rte_pktmbuf_free(mbufs[i]);
> +	}
> +
>  	rte_bitmap_free(port->bmp);
>  	rte_free(port);
>  }
> @@ -1032,23 +1059,6 @@ rte_sched_port_qindex(struct rte_sched_port *port, uint32_t subport, uint32_t pi
>  	return result;
>  }
>  
> -static inline struct rte_mbuf **
> -rte_sched_port_qbase(struct rte_sched_port *port, uint32_t qindex)
> -{
> -	uint32_t pindex = qindex >> 4;
> -	uint32_t qpos = qindex & 0xF;
> -
> -	return (port->queue_array + pindex * port->qsize_sum + port->qsize_add[qpos]);
> -}
> -
> -static inline uint16_t
> -rte_sched_port_qsize(struct rte_sched_port *port, uint32_t qindex)
> -{
> -	uint32_t tc = (qindex >> 2) & 0x3;
> -
> -	return port->qsize[tc];
> -}
> -
>  #if RTE_SCHED_DEBUG
>  
>  static inline int
> 

  reply	other threads:[~2015-11-04  7:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28  9:56 Simon Kagstrom
2015-11-04  7:49 ` Simon Kågström [this message]
2015-11-04 18:14 ` Stephen Hemminger
2015-11-17  7:53   ` Simon Kågström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5639B899.7080006@netinsight.net \
    --to=simon.kagstrom@netinsight.net \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).