From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id 7B6FC5A69 for ; Fri, 6 Nov 2015 02:42:53 +0100 (CET) Received: by pasz6 with SMTP id z6so108880902pas.2 for ; Thu, 05 Nov 2015 17:42:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel_co_jp.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=tyP8RvcBbpblQ3heQruB1j6ORCgkYjVOwEa+lihkNa4=; b=o+MGzUB8262pgywp5q1OJ4LFV7Rett7aVPiImesWLunw93Z0wK4AXbTzUDr+5CzCv3 30p4tcIT/r7PkcGF1DeeySIG8bcAcketXCCdmLJUF8cf1as/OsYAXrSoyZjwhyBoY3KA m7QlHr6cikhLARlLsZumC56rkwyaWXqu5/uPuzVk9Iaf7LRwJepKRrlluLUySErPcqb8 P1c9juy1tRwyRh+YD6Nk82wQyio1JoyGqNZV+AbArzkEIP0XgosgklV40TSYWXsnO+CD BABAoCNWrs0XQe2Uqa1+1k0rGPyKfpC8cSCiPGGoCAkfmPLGWMznJpcZCHICKS/wIW1d Y/nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=tyP8RvcBbpblQ3heQruB1j6ORCgkYjVOwEa+lihkNa4=; b=Is+JXUGsaPKLelCd2yS554XCCqBwIrSBoF3pSB31mwmcDmT2TUnpStLCaFrv7vvARX fAXefRl8RuQMrngvxp81t/lMYHe0ANa9d5k7tjs3vnmeeK4AvRf78BBprfhCP765Iz6Q U86Q5B6mPOIPdC/dtZ0wWYziy3TW9TvO3uPxJ4UwY+ttFq8n6Yj0YYvB/soO+s/rrqOQ 31ZvZMTaJsdbIec+XXpZDrpLOCDkKdhJt2utecgrQEANMeHCr/T1TZyCADt+ZQDZ2wal IpKKi81XpUi8YsbgELno37E66xpf8G/MthluKjdeWPSQQXZ1Yh8XWYen/Np/DJOBX9p7 89HQ== X-Gm-Message-State: ALoCoQlpOw7+kjt9kFUBLHmY/LuT6/u4lj4ooNKxMx2fReFPt29p/9vd2J2oD2pPilCWIo73XDWX X-Received: by 10.69.1.9 with SMTP id bc9mr13628983pbd.152.1446774172730; Thu, 05 Nov 2015 17:42:52 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id ha1sm10210169pbc.54.2015.11.05.17.42.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Nov 2015 17:42:52 -0800 (PST) To: "Xie, Huawei" , "dev@dpdk.org" References: <1446658952-101192-1-git-send-email-huawei.xie@intel.com> From: Tetsuya Mukawa X-Enigmail-Draft-Status: N1110 Message-ID: <563C0598.1040205@igel.co.jp> Date: Fri, 6 Nov 2015 10:42:48 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "haifeng.lin@intel.com" , "ann.zhuangyanying@huawei.com" Subject: Re: [dpdk-dev] [RFC PATCH] vhost: remove lockless enqueue to virt ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2015 01:42:53 -0000 On 2015/11/05 19:21, Xie, Huawei wrote: > If no objections, would remove the internal cmpset enqueue, should get > some improved performance. > > No idea why commit message is lost: > DPDK doesn't support receiving/transmitting packets from/to the same > port/queue. > Vhost pmd wraps vhost device as normal dpdk port. dpdkvhost based > applications/switch > also treate virtio port and physical port both as ports, and have > their own > lock implmentation when to enqueue packets to the same port. This patch > removes > the internal lockless vhost enqueue implmentation. > On 11/5/2015 5:38 PM, Huawei Xie wrote: >> Signed-off-by: Huawei Xie Hi Xie, I think it's a good optimization. But I guess the patch will changes behavior of vhost library API. For example, if someone has already implemented an application based on the assumption that vhost library has internal lock, I doubt their application will face an issue with this patch. If it's correct, we might need to follow below steps. http://dpdk.org/doc/guides/contributing/versioning.html Thanks, Tetsuya