From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 433C1A32A2 for ; Fri, 25 Oct 2019 10:21:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C25361E87D; Fri, 25 Oct 2019 10:21:05 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 153A71E549 for ; Fri, 25 Oct 2019 10:21:03 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2019 01:21:03 -0700 X-IronPort-AV: E=Sophos;i="5.68,228,1569308400"; d="scan'208";a="202548139" Received: from dhunt5-mobl4.ger.corp.intel.com (HELO [10.237.221.107]) ([10.237.221.107]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/AES256-SHA; 25 Oct 2019 01:21:01 -0700 To: David Marchand Cc: dev , Harman Kalra , Gavin Hu , Honnappa Nagarahalli , nd , Ruifeng Wang References: <20191008095524.1585-1-ruifeng.wang@arm.com> <20191015092826.13002-1-ruifeng.wang@arm.com> <1b48d0a1-a4c0-f5f8-0246-2e050893f2c3@intel.com> From: "Hunt, David" Message-ID: <563ac490-809f-1e8c-6f07-3ddfb7e72687@intel.com> Date: Fri, 25 Oct 2019 09:20:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v3 0/2] fix distributor unit test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 25/10/2019 09:18, David Marchand wrote: > On Fri, Oct 25, 2019 at 10:11 AM Hunt, David wrote: >> >> On 24/10/2019 20:31, David Marchand wrote: >>> On Tue, Oct 15, 2019 at 11:29 AM Ruifeng Wang wrote: >>>> Bug 342 reported distributor_autotest execution suspension >>>> on aarch64 platform. >>>> Issue was due to lack of synchronization among threads. Distributor >>>> thread and worker thread may get deadlocked. >>>> Fixed synchronization issue by adding barriers. >>>> >>>> Another issue identified was in test case. Non-atomic operation on >>>> stat value could cause value reset not been observed by worker thread >>>> and mess counters. The issue was fixed by using atomic operations. >>>> >>>> --- >>>> v3: >>>> Added comments for using of C11 acquire/release semantics. (Honnappa) > The comments are also something to maintain, so checking the v3 made > sense to me.   I agree, and the comments look good to me. > >>>> v2: >>>> Fixed intermittent packet count incorrect failure. (Aaron, David) >>>> Fixed Clang build on 32bit systems. >>>> Additional patch to fix non-atomic operation in unit test. >>> David, >>> >>> Can you review this series? >>> Thanks. >>> >> Hi David, >> >> I had tested this previously, including performance comparisons >> against original version on x86, and saw no performance degradation, so >> I Acked it. I can re-ack on the latest version now. > If you think this is fine as is, I will go and apply with your ack. Sure, thanks. Regards, Dave.