From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id 07D485921 for ; Tue, 10 Nov 2015 04:51:47 +0100 (CET) Received: by pabfh17 with SMTP id fh17so220713320pab.0 for ; Mon, 09 Nov 2015 19:51:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel_co_jp.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=FNFPJPU5uC8oX3CsK7QbXEgLqvySoeRtnEc9haWBhAE=; b=mxmA+jkLYncofftcjt2YZgUm8iv51eLtUxt0Zw+KvpoCy1/6G6R7WQ8csbPX88j1PD 6kL0UTr1qV3GEf5FPT51avAdx97FLEHlnzlSignBEj1PidEb6BjfxHpZ59dl/42Qq5gz eD2tGFjgsiRvrjnx1mym0G4pIXa9lY7HQIgfXn/YB42CMP0b57mexnDcfaDy5b5SzOUX tt/70EAR1askZvGjLF1P9O7MhgLH2JSdQHpjFNnNXQjTo/s6vhyQaCxDP3c941ExBEQ0 6wnrWIAQShc9I2y9hrDnfl6Lruy/oCZ24S8jZUQKpTlcz6c07RJ1c9XmCvztU3yxBDF1 MP0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=FNFPJPU5uC8oX3CsK7QbXEgLqvySoeRtnEc9haWBhAE=; b=ehiR9lzZqc1y9L4Qjd60o68/DsnYoQaOklubPCwxH/LqTFOQqOfNtg7RjyjKutAo29 fJQs1nN4eypnCyCfQ+/koJkWL6I7Qxo0+paP4RXNrKnJSCfnUncjkjFcjFwlvxBhjd28 G6fiGIpvtNj6V8uVLT3z1xAsgtuL8+pj/J+ItN6exSQ/G446Mx3vheZB0C1EH1Ffx7Ug wM+PTzdc1Z1YJ2fjIK7cPPxyCDHUI0Rc7Z21i1Tz3UV7XaocSRV3XEMGaxn4u7tWYQoZ FwtPU8Dq8tPjzve3q4Q4Ehfiv+SAaXlrQA8cS5+fueMmQuMH74DqHiivpBXea6r6tmvf yu3g== X-Gm-Message-State: ALoCoQmGWtud8b22YhXceS/CjLCJmqA83UR2z7f/TntArSiw1g50Ae13NRqKKHNqujxkzLrjD9qv X-Received: by 10.68.226.41 with SMTP id rp9mr2268094pbc.55.1447127506345; Mon, 09 Nov 2015 19:51:46 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id di2sm1021243pbc.64.2015.11.09.19.51.44 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 09 Nov 2015 19:51:45 -0800 (PST) To: Yuanhan Liu , Rich Lane References: <1447121713-12095-1-git-send-email-rlane@bigswitch.com> <20151110022523.GR2326@yliu-dev.sh.intel.com> From: Tetsuya Mukawa X-Enigmail-Draft-Status: N1110 Message-ID: <564169CE.5020909@igel.co.jp> Date: Tue, 10 Nov 2015 12:51:42 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151110022523.GR2326@yliu-dev.sh.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] vhost: make destroy callback on VHOST_USER_RESET_OWNER X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 03:51:47 -0000 On 2015/11/10 11:25, Yuanhan Liu wrote: > On Mon, Nov 09, 2015 at 06:15:13PM -0800, Rich Lane wrote: >> QEMU sends this message first when shutting down. There was previously no way >> for the dataplane to know that the virtio_net instance had become unusable and >> it would segfault when trying to do RX/TX. >> >> Signed-off-by: Rich Lane > Thanks. Even I have same patch in my patch queue (I have some other > issues to fix), you got my ack. > > Acked-by: Yuanhan Liu > > --yliu > Hi Liu and Rich, How about saving "dev->ifname" while processing reset_owner like "dev->device_fh"? It was only set when connection is established. But so far, it will be cleared when reset_owner message comes. Probably it should be cleared when unix domain socket connection is closed. Thanks, Tetsuya >> --- >> lib/librte_vhost/virtio-net.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c >> index 14278de..39a6a5e 100644 >> --- a/lib/librte_vhost/virtio-net.c >> +++ b/lib/librte_vhost/virtio-net.c >> @@ -436,6 +436,9 @@ reset_owner(struct vhost_device_ctx ctx) >> if (dev == NULL) >> return -1; >> >> + if (dev->flags & VIRTIO_DEV_RUNNING) >> + notify_ops->destroy_device(dev); >> + >> device_fh = dev->device_fh; >> cleanup_device(dev); >> init_device(dev); >> -- >> 1.9.1