From: "Roger B. Melton" <rmelton@cisco.com>
To: David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Making rte_eal_pci_probe() in rte_eal_init() optional?
Date: Fri, 13 Nov 2015 07:07:00 -0500 [thread overview]
Message-ID: <5645D264.7040201@cisco.com> (raw)
In-Reply-To: <CALwxeUsi80NBbp_Z7dh5MdRp0L6qOV5ph-VcE-Sd_htk2X2=jg@mail.gmail.com>
Hi David,
On 11/13/15 3:49 AM, David Marchand wrote:
> Hello Roger,
>
> On Thu, Nov 12, 2015 at 11:43 PM, Roger B Melton <rmelton@cisco.com
> <mailto:rmelton@cisco.com>> wrote:
>
> Hi folks,
>
> With the addition of hot plug support we have been migrating away
> from device discovery and attach at initialization time to a model
> where it is controlled from a separate process. The separate
> process manages the binding of devices to UIO and instructs the
> DPDK process when to attach. One of the problems we stumbled onto
> was that if our control process discovered devices and bound them
> to UIO before our DPDK process started, then rte_eal_init() would
> discover and attach to those devices via the rte_eal_pci_probe()
> invocation. This caused problems later on when when our control
> process, instructed our DPDK process to attach to a device.
>
> There are a number of ways we could address this, but the simplest
> is to prevent the rte_eal_pci_probe() at rte_eal_init() time. In
> our model we will never need it and I suspect others may also be
> in that boat.
>
> What are your thoughts on adding an argument to instruct
> rte_eal_init() to skip the PCI probe?
>
>
> Did you try the --no-pci option ?
> It avoids the initial sysfs scan, so with no pci device, the initial
> pci_probe should do nothing.
>
> Attaching devices later will trigger this sysfs scan and only probe
> the requested device.
> I am not totally happy with the way it is done right now, but I think
> this should work for you.
I saw it, but I was so caught up in the probe that I didn't consider
that delaying the scan until attach time might solve the problem.
I'll give it shot. Thanks for pointing it out David.
Regards,
-Roger
>
>
> --
> David Marchand
--
____________________________________________________________________
|Roger B. Melton | | Cisco Systems |
|CPP Software :|: :|: 7100 Kit Creek Rd |
|+1.919.476.2332 phone :|||: :|||: RTP, NC 27709-4987 |
|+1.919.392.1094 fax .:|||||||:..:|||||||:. rmelton@cisco.com |
| |
| This email may contain confidential and privileged material for the|
| sole use of the intended recipient. Any review, use, distribution |
| or disclosure by others is strictly prohibited. If you are not the |
| intended recipient (or authorized to receive for the recipient), |
| please contact the sender by reply email and delete all copies of |
| this message. |
| |
| For corporate legal information go to: |
| http://www.cisco.com/web/about/doing_business/legal/cri/index.html |
|__________________________ http://www.cisco.com ____________________|
next prev parent reply other threads:[~2015-11-13 12:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 22:43 Roger B Melton
2015-11-13 8:49 ` David Marchand
2015-11-13 12:07 ` Roger B. Melton [this message]
2015-11-13 22:58 Don Provan
2015-11-13 23:03 ` Jan Viktorin
2015-11-14 15:55 ` Roger B. Melton
2015-11-14 17:51 ` David Marchand
2015-11-15 14:45 ` Roger B. Melton
2015-11-16 9:46 ` David Marchand
2015-11-17 13:56 ` Roger B. Melton
2015-11-17 15:46 ` Thomas Monjalon
2015-11-18 22:13 ` Roger B. Melton
2015-11-21 12:54 ` Roger B. Melton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5645D264.7040201@cisco.com \
--to=rmelton@cisco.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).