DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jijiang Liu <jijiang.liu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2]xen:reserve memory at installing dom0_mm kernel module
Date: Fri, 23 May 2014 10:19:59 +0200	[thread overview]
Message-ID: <5649427.rlZUqcKHhV@xps13> (raw)
In-Reply-To: <1400827990-14324-1-git-send-email-jijiang.liu@intel.com>

Hi Jijiang,

2014-05-23 14:53, Jijiang Liu:
> The patch changes the way of reserving memory in Dom0 driver. It will
> reserve memory at installing rte_dom0_mm.ko kernel module instead of
> requesting memory dynamically during DPDK application startup. Meanwhile,
> now driver requests memory size of 4M once first, if it failed, and request
> memory size of 2M once. The main reasons we do these changes as follows:
> 
> First, to reduce the impact of inceasing in memory fragment after system run
> a long time. Second, to reduce number of memory segment
> 
> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> ---

Thanks for sending new version of this patch.

Just a note for next time, as explained in this page:
	http://dpdk.org/dev#send
it's a good practice do put a changelog after the 3 dashes. It allows to us to 
understand why this new version is for.

In this case, the changelog should be:

changes in v2:
- fix code style according to checkpatch.pl

Thanks
-- 
Thomas

  reply	other threads:[~2014-05-23  8:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23  6:53 Jijiang Liu
2014-05-23  8:19 ` Thomas Monjalon [this message]
2014-05-23  8:25   ` Liu, Jijiang
2014-05-29  9:47 ` Thomas Monjalon
2014-06-05 12:11 ` Cao, Waterman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5649427.rlZUqcKHhV@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=jijiang.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).