From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 0DBA7593A for ; Fri, 23 May 2014 10:19:54 +0200 (CEST) Received: by mail-wg0-f47.google.com with SMTP id x12so4378250wgg.18 for ; Fri, 23 May 2014 01:20:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=1gmvW/fPaF4bPiZ3VGzCa8IIL4uQs5d7PmgLVC/Qwmg=; b=kIDcaK1FFWoQ7ffzQRYTgcc/4VU/JYGlp6iAqlHR7wbhyE+oWL6DLQacyP1mrrar6L /1tAVvpFCYEUnLfaPHLXbLgztI2aUv+S9/ZeayQC+NuOMqv3369xGqwTgI5Qw16Rmltm hyB8i6E7qUdoxLnVbh0d9CCykyLkbhsgoT0YrkIreSLXUb0HYNWPXk4HqulQ7iQ597it Xsy3MUoOcWCI6KWTIbkGB3sPBk7p9Ve2gUnBxjockoPoHgdh0+uVPBibAa7qIfP4Z4TY uw6ZlK5QmyEaY1N5Igh/hcIpyu+od8t/u5gWNdVbpvZfLan4tuG93rc2LHYPdNVy+oW2 H37Q== X-Gm-Message-State: ALoCoQnKID3vr2s7W9VyZXEJNzk9wpdeffuPhmYk/tqnmf51RiK+nP5tBeV84yiReCNzFRt++eZj X-Received: by 10.195.11.131 with SMTP id ei3mr2665520wjd.23.1400833204702; Fri, 23 May 2014 01:20:04 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id gd5sm2931855wjb.40.2014.05.23.01.20.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 May 2014 01:20:03 -0700 (PDT) From: Thomas Monjalon To: Jijiang Liu Date: Fri, 23 May 2014 10:19:59 +0200 Message-ID: <5649427.rlZUqcKHhV@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <1400827990-14324-1-git-send-email-jijiang.liu@intel.com> References: <1400827990-14324-1-git-send-email-jijiang.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2]xen:reserve memory at installing dom0_mm kernel module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 May 2014 08:19:55 -0000 Hi Jijiang, 2014-05-23 14:53, Jijiang Liu: > The patch changes the way of reserving memory in Dom0 driver. It will > reserve memory at installing rte_dom0_mm.ko kernel module instead of > requesting memory dynamically during DPDK application startup. Meanwhile, > now driver requests memory size of 4M once first, if it failed, and request > memory size of 2M once. The main reasons we do these changes as follows: > > First, to reduce the impact of inceasing in memory fragment after system run > a long time. Second, to reduce number of memory segment > > Signed-off-by: Jijiang Liu > --- Thanks for sending new version of this patch. Just a note for next time, as explained in this page: http://dpdk.org/dev#send it's a good practice do put a changelog after the 3 dashes. It allows to us to understand why this new version is for. In this case, the changelog should be: changes in v2: - fix code style according to checkpatch.pl Thanks -- Thomas