From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <simon.kagstrom@netinsight.net> Received: from ernst.netinsight.se (ernst.netinsight.se [194.16.221.21]) by dpdk.org (Postfix) with SMTP id 9C52858D4 for <dev@dpdk.org>; Tue, 17 Nov 2015 08:53:19 +0100 (CET) Received: from [10.100.1.152] (unverified [10.100.1.152]) by ernst.netinsight.se (EMWAC SMTPRS 0.83) with SMTP id <B0031636065@ernst.netinsight.se>; Tue, 17 Nov 2015 08:53:17 +0100 To: Stephen Hemminger <stephen@networkplumber.org> References: <20151028105633.6a507c98@miho> <20151104101426.2f771b45@xeon-e3> From: =?UTF-8?Q?Simon_K=c3=a5gstr=c3=b6m?= <simon.kagstrom@netinsight.net> Message-ID: <564ADCED.2050100@netinsight.net> Date: Tue, 17 Nov 2015 08:53:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151104101426.2f771b45@xeon-e3> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] rte_sched: release enqueued mbufs on rte_sched_port_free() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 17 Nov 2015 07:53:19 -0000 On 2015-11-04 19:14, Stephen Hemminger wrote: > On Wed, 28 Oct 2015 10:56:33 +0100 > Simon Kagstrom <simon.kagstrom@netinsight.net> wrote: > >> Otherwise mbufs will leak when the port is destroyed. The >> rte_sched_port_qbase() and rte_sched_port_qsize() functions are used >> in free now, so move them up. >> >> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net> > > Overall it looks good, and fixes a long standing bug. > Maybe good to expose it as a API function rte_sched_port_flush > to allow use from applications. I'm sorry, I missed this reply! I will fix the issues you point to and repost. // Simon