From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D39AB5A8C for ; Tue, 17 Nov 2015 15:45:41 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 17 Nov 2015 06:45:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,308,1444719600"; d="scan'208";a="852772034" Received: from dwdohert-dpdk-fedora-20.ir.intel.com (HELO dwdohert-dpdk-fedora-23.ir.intel.com) ([163.33.213.71]) by orsmga002.jf.intel.com with ESMTP; 17 Nov 2015 06:45:39 -0800 To: dev@dpdk.org, Thomas Monjalon References: <1447176763-19303-1-git-send-email-declan.doherty@intel.com> <1447441090-8129-1-git-send-email-declan.doherty@intel.com> <1447441090-8129-2-git-send-email-declan.doherty@intel.com> From: Declan Doherty Message-ID: <564B3D66.7070300@intel.com> Date: Tue, 17 Nov 2015 14:44:54 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447441090-8129-2-git-send-email-declan.doherty@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 01/10] ethdev: rename macros to have RTE_ prefix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2015 14:45:42 -0000 On 13/11/15 18:58, Declan Doherty wrote: > The macros to check that the function pointers and port ids are valid > for an ethdev are potentially useful to have in a common headers for > use with all PMDs. However, since they would then become externally > visible, we apply the RTE_ & RTE_ETH_ prefix to them as approtiate. > > Signed-off-by: Declan Doherty > Acked-by: Bruce Richardson > > --- > lib/librte_ether/rte_ethdev.c | 595 +++++++++++++++++++++--------------------- > 1 file changed, 298 insertions(+), 297 deletions(-) > > Hey Thomas, this patch needs to be re-based due to the committal of Daniel's patch "ethdev: add ieee1588 functions for device clock time" is it ok to just send an updated patch for this single patch as it doesn't effect the other 9 patches in the series? Thanks Declan