DPDK patches and discussions
 help / color / mirror / Atom feed
From: Panu Matilainen <pmatilai@redhat.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix missing symbol export for rte_eth_dma_zone_reserve()
Date: Wed, 18 Nov 2015 14:16:49 +0200	[thread overview]
Message-ID: <564C6C31.9090605@redhat.com> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2023BE69A@IRSMSX103.ger.corp.intel.com>

On 11/18/2015 01:48 PM, Mcnamara, John wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen
>> Sent: Wednesday, November 18, 2015 7:34 AM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] ethdev: fix missing symbol export for
>> rte_eth_dma_zone_reserve()
>>
>> Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime")
>>
>> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
>
> Out of curiosity, how did you identify this issue?

These kind of issues are hard not to notice when using shared library 
configuration once there's something actually using the symbol. In this 
case, the four commits following 719dbebceb81 make the e1000, ixgbe, i40 
and fm10k pmds unloadable respectively:

librte_pmd_ixgbe.so: undefined symbol: rte_eth_dma_zone_reserve

Driver autoloading does help unearthing these issues too since all the 
pmd's get loaded regardless of the actual hardware present.

	- Panu -

  reply	other threads:[~2015-11-18 12:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <b2c9de21812b030103d11d6cf62ba7895441885d.1447832032.git.pmatilai@redhat.com>
2015-11-18 11:48 ` Mcnamara, John
2015-11-18 12:16   ` Panu Matilainen [this message]
2015-11-23 21:22   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564C6C31.9090605@redhat.com \
    --to=pmatilai@redhat.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).