From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pmatilai@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 52A9D5A68
 for <dev@dpdk.org>; Wed, 18 Nov 2015 13:16:52 +0100 (CET)
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
 (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
 by mx1.redhat.com (Postfix) with ESMTPS id 86BF38E226;
 Wed, 18 Nov 2015 12:16:51 +0000 (UTC)
Received: from sopuli.koti.laiskiainen.org (vpn1-7-206.ams2.redhat.com
 [10.36.7.206])
 by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 tAICGo1Q021072; Wed, 18 Nov 2015 07:16:50 -0500
To: "Mcnamara, John" <john.mcnamara@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
References: <b2c9de21812b030103d11d6cf62ba7895441885d.1447832032.git.pmatilai@redhat.com>
 <B27915DBBA3421428155699D51E4CFE2023BE69A@IRSMSX103.ger.corp.intel.com>
From: Panu Matilainen <pmatilai@redhat.com>
Message-ID: <564C6C31.9090605@redhat.com>
Date: Wed, 18 Nov 2015 14:16:49 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2023BE69A@IRSMSX103.ger.corp.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix missing symbol export for
 rte_eth_dma_zone_reserve()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Nov 2015 12:16:52 -0000

On 11/18/2015 01:48 PM, Mcnamara, John wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen
>> Sent: Wednesday, November 18, 2015 7:34 AM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] ethdev: fix missing symbol export for
>> rte_eth_dma_zone_reserve()
>>
>> Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime")
>>
>> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
>
> Out of curiosity, how did you identify this issue?

These kind of issues are hard not to notice when using shared library 
configuration once there's something actually using the symbol. In this 
case, the four commits following 719dbebceb81 make the e1000, ixgbe, i40 
and fm10k pmds unloadable respectively:

librte_pmd_ixgbe.so: undefined symbol: rte_eth_dma_zone_reserve

Driver autoloading does help unearthing these issues too since all the 
pmd's get loaded regardless of the actual hardware present.

	- Panu -