Re: [dpdk-dev] [PATCH] mk: fix compilation for icc version 16

[Olivier MATZ <olivier.matz@6wind.com>]

Hi,

On 11/20/2015 03:34 PM, Declan Doherty wrote:
> This patch changes the ICC conditional check to disable
> -no-inline-max-size and -no-inline-max-total-size to be
> for all versions of icc greater than 14 and not just for version 15.
> 
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> ---
>  mk/toolchain/icc/rte.vars.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk
> index e39d710..9b6b34b 100644
> --- a/mk/toolchain/icc/rte.vars.mk
> +++ b/mk/toolchain/icc/rte.vars.mk
> @@ -74,8 +74,8 @@ WERROR_FLAGS += -diag-disable 13368 -diag-disable 15527
>  
>  # process cpu flags
>  include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk
> -# disable max-inline params boundaries for ICC 15 compiler
> -ifeq ($(shell test $(ICC_MAJOR_VERSION) -eq 15 && echo 1), 1)
> +# disable max-inline params boundaries for ICC compiler for version 15 and greater
> +ifeq ($(shell test $(ICC_MAJOR_VERSION) -ge 14 && echo 1), 1)
>  	TOOLCHAIN_CFLAGS += -no-inline-max-size -no-inline-max-total-size
>  endif
>  
> 

Acked-by: Olivier Matz <olivier.matz@6wind.com>