From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 735D78DA8
 for <dev@dpdk.org>; Fri, 20 Nov 2015 16:34:55 +0100 (CET)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10])
 by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84) (envelope-from <olivier.matz@6wind.com>)
 id 1Zznio-00049P-NH; Fri, 20 Nov 2015 16:35:36 +0100
Message-ID: <564F3D98.9060708@6wind.com>
Date: Fri, 20 Nov 2015 16:34:48 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.7.0
MIME-Version: 1.0
To: Declan Doherty <declan.doherty@intel.com>, dev@dpdk.org
References: <1448030073-30711-1-git-send-email-declan.doherty@intel.com>
In-Reply-To: <1448030073-30711-1-git-send-email-declan.doherty@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] mk: fix compilation for icc version 16
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Nov 2015 15:34:55 -0000

Hi,

On 11/20/2015 03:34 PM, Declan Doherty wrote:
> This patch changes the ICC conditional check to disable
> -no-inline-max-size and -no-inline-max-total-size to be
> for all versions of icc greater than 14 and not just for version 15.
> 
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> ---
>  mk/toolchain/icc/rte.vars.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk
> index e39d710..9b6b34b 100644
> --- a/mk/toolchain/icc/rte.vars.mk
> +++ b/mk/toolchain/icc/rte.vars.mk
> @@ -74,8 +74,8 @@ WERROR_FLAGS += -diag-disable 13368 -diag-disable 15527
>  
>  # process cpu flags
>  include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk
> -# disable max-inline params boundaries for ICC 15 compiler
> -ifeq ($(shell test $(ICC_MAJOR_VERSION) -eq 15 && echo 1), 1)
> +# disable max-inline params boundaries for ICC compiler for version 15 and greater
> +ifeq ($(shell test $(ICC_MAJOR_VERSION) -ge 14 && echo 1), 1)
>  	TOOLCHAIN_CFLAGS += -no-inline-max-size -no-inline-max-total-size
>  endif
>  
> 

Acked-by: Olivier Matz <olivier.matz@6wind.com>