DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier MATZ <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: fix extra options when linking lib through compiler
Date: Fri, 20 Nov 2015 16:40:29 +0100	[thread overview]
Message-ID: <564F3EED.6040908@6wind.com> (raw)
In-Reply-To: <1448028175-22022-1-git-send-email-thomas.monjalon@6wind.com>

Hi,

On 11/20/2015 03:02 PM, Thomas Monjalon wrote:
> When using a linker option not known by the compiler like -rpath,
> the library linkage was failing.
> It is fixed by prefixing the option with -Wl, as it is done in other
> makefiles.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  mk/rte.lib.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
> index fcc8e20..06a1519 100644
> --- a/mk/rte.lib.mk
> +++ b/mk/rte.lib.mk
> @@ -68,6 +68,7 @@ ifeq ($(LINK_USING_CC),1)
>  # Override the definition of LD here, since we're linking with CC
>  LD := $(CC) $(CPU_CFLAGS)
>  _CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS))
> +override EXTRA_LDFLAGS := $(call linkerprefix,$(EXTRA_LDFLAGS))
>  else
>  _CPU_LDFLAGS := $(CPU_LDFLAGS)
>  endif
> 

Acked-by: Olivier Matz <olivier.matz@6wind.com>

  reply	other threads:[~2015-11-20 15:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 14:02 Thomas Monjalon
2015-11-20 15:40 ` Olivier MATZ [this message]
2015-11-20 16:17   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564F3EED.6040908@6wind.com \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).