From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <olivier.matz@6wind.com> Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 71298378E for <dev@dpdk.org>; Fri, 20 Nov 2015 17:28:50 +0100 (CET) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84) (envelope-from <olivier.matz@6wind.com>) id 1ZzoZ0-0004CH-Li; Fri, 20 Nov 2015 17:29:31 +0100 Message-ID: <564F4A3B.5080204@6wind.com> Date: Fri, 20 Nov 2015 17:28:43 +0100 From: Olivier MATZ <olivier.matz@6wind.com> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: "Mcnamara, John" <john.mcnamara@intel.com>, Nelio Laranjeiro <nelio.laranjeiro@6wind.com>, "dev@dpdk.org" <dev@dpdk.org> References: <1447087700-20921-1-git-send-email-nelio.laranjeiro@6wind.com> <B27915DBBA3421428155699D51E4CFE2023B7307@IRSMSX103.ger.corp.intel.com> In-Reply-To: <B27915DBBA3421428155699D51E4CFE2023B7307@IRSMSX103.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 20 Nov 2015 16:28:50 -0000 Hi Nélio, On 11/10/2015 06:29 PM, Mcnamara, John wrote: > > >> -----Original Message----- >> From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] >> Sent: Monday, November 9, 2015 4:48 PM >> To: dev@dpdk.org >> Cc: olivier.matz@6wind.com; thomas.monjalon@6wind.com; Mcnamara, John; Lu, >> Wenzhuo >> Subject: [PATCH 1/2] doc: announce ABI change for cmdline buffer size >> >> Current buffer size are not enough for a few testpmd commands. >> >> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > > Acked-by: John McNamara <john.mcnamara@intel.com> > While I'm not fundamentally opposed to change the buffer size, I'm wondering if the impacted commands shouldn't be reworked to have smaller lines. 256 is already a quite big value for a line: 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345 For instance, we could change some commands to use contexts. Dummy example with reta config: testpmd> port config 0 rss reta testpmd-reta-config-0> add hash1 queue1 testpmd-reta-config-0> add hash2 queue2 testpmd-reta-config-0> del hash1 queue1 testpmd-reta-config-0> show testpmd-reta-config-0> commit testpmd> What do you think? Regards, Olivier